From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58282 invoked by alias); 9 Jan 2019 00:40:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58263 invoked by uid 89); 9 Jan 2019 00:40:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=excuse, prevent, Hx-languages-length:761 X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.145.3) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Jan 2019 00:40:55 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 2B0135A6C for ; Tue, 8 Jan 2019 18:40:54 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id h1vSgcUXB90onh1vSg6dcB; Tue, 08 Jan 2019 18:40:54 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=avbGZ5scMHs578MKiAZUMDyQyFFlejdYRzDhGO9FHfo=; b=v+hyq0kQnxC9eOGqXGsz8EGcFL 5ZGpLV0iqwFZEalthBJCrpk01S5DyemUVA9VmjYEmLex9S8uQDMLcijkOvlk6qyu9DnbFSKh23CPN nZM4uVion68iWzl6LF37yHfZV; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:57700 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gh1vR-0046b9-Ri; Tue, 08 Jan 2019 18:40:53 -0600 From: Tom Tromey To: Simon Marchi Cc: Philippe Waroquiers , "gdb-patches\@sourceware.org" , Tom Tromey Subject: Re: [RFA] Fix leak in linespec.c References: <20190108062452.3942-1-philippe.waroquiers@skynet.be> <2c12aba6-cafa-54e2-9b69-96d95b82d3fb@ericsson.com> Date: Wed, 09 Jan 2019 00:40:00 -0000 In-Reply-To: <2c12aba6-cafa-54e2-9b69-96d95b82d3fb@ericsson.com> (Simon Marchi's message of "Tue, 8 Jan 2019 23:39:40 +0000") Message-ID: <8736q2zmqz.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-01/txt/msg00155.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> ... so you are adding the equivalent of the first cleanup. Oops,sorry about that. I hope eventually either we have ASAN and perhaps LSAN enabled in development builds; or that it becomes a lot simpler to run tests under valgrind... not trying to excuse my error, just trying to see how I could prevent it next time. Simon> It would be nice to be able to free the suffix strings in linespec_state_destructor, the Simon> only problem is that we don't know the size of the canonical_names array at that point. linespec would definitely benefit from a couple more rounds of C++-ification. Some of the changes spill out into the rest of gdb though. Tom