Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Gary Benson <gbenson@redhat.com>
Cc: Tom Tromey <tom@tromey.com>,  gdb-patches@sourceware.org
Subject: Re: [OB PATCH] Fix gnulib/update-gnulib.sh
Date: Fri, 21 Jun 2019 22:01:00 -0000	[thread overview]
Message-ID: <8736k2ha3h.fsf@tromey.com> (raw)
In-Reply-To: <20190621134342.GA32648@blade.nx> (Gary Benson's message of "Fri,	21 Jun 2019 14:43:43 +0100")

>> Tom, even the changes I committed I'm not convinced update-gnulib.sh
>> is working 100% correctly.  Running it as-is (i.e. "updating" to the
>> version we already have) changes a bunch of autotools files, and I
>> can't figure out why.  Could you have a quick look at what it's
>> changing and let me know if the changes below are something I should
>> be checking in, or, if not, what it is I need to update cleanly.

Gary> Sorry, I missed the "what it's changing" I wanted you to look at!

Gary> diff --git a/gnulib/aclocal.m4 b/gnulib/aclocal.m4

When I tried this, I saw some of the changes you saw, but not this one.

Gary> diff --git a/gnulib/configure b/gnulib/configure

Also did not see this one.

Did you re-run aclocal and if so did you pass the correct options?
That's the only thing I could think of.

The other changes look fine.  I guess maybe I didn't re-run the
autoreconf after some tweak, plus maybe the update script updated the m4
dependencies to be more correct.

Tom


  reply	other threads:[~2019-06-21 22:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-21 12:26 Gary Benson
2019-06-21 13:19 ` Gary Benson
2019-06-21 13:43   ` Gary Benson
2019-06-21 22:01     ` Tom Tromey [this message]
2019-06-21 16:07 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8736k2ha3h.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gbenson@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox