From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67609 invoked by alias); 21 Jun 2019 22:01:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 67599 invoked by uid 89); 21 Jun 2019 22:01:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-12.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.231) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Jun 2019 22:01:09 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway34.websitewelcome.com (Postfix) with ESMTP id E5F3E31621 for ; Fri, 21 Jun 2019 17:01:07 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id eRalhbhtRdnCeeRalhCEwI; Fri, 21 Jun 2019 17:01:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eZSbjGPwQbA1aVZfma8PpcMxyvsS7hpZgLPLM3ALVTo=; b=ikfwBYAGUGTIN9buOJfLfMsxJJ taDM9NCOb+wWvexze6Dh8UXpy92opGxti61TfjgcuVilwAimmEqQ+7U1HuK5go6MtPwln6HybOq2f ZGfXuWU9pStUoqJqIG9OeKOgc; Received: from 75-166-12-78.hlrn.qwest.net ([75.166.12.78]:50760 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1heRal-002MXs-N5; Fri, 21 Jun 2019 17:01:07 -0500 From: Tom Tromey To: Gary Benson Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [OB PATCH] Fix gnulib/update-gnulib.sh References: <1561119986-23683-1-git-send-email-gbenson@redhat.com> <20190621131019.GA9536@blade.nx> <20190621134342.GA32648@blade.nx> Date: Fri, 21 Jun 2019 22:01:00 -0000 In-Reply-To: <20190621134342.GA32648@blade.nx> (Gary Benson's message of "Fri, 21 Jun 2019 14:43:43 +0100") Message-ID: <8736k2ha3h.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-06/txt/msg00449.txt.bz2 >> Tom, even the changes I committed I'm not convinced update-gnulib.sh >> is working 100% correctly. Running it as-is (i.e. "updating" to the >> version we already have) changes a bunch of autotools files, and I >> can't figure out why. Could you have a quick look at what it's >> changing and let me know if the changes below are something I should >> be checking in, or, if not, what it is I need to update cleanly. Gary> Sorry, I missed the "what it's changing" I wanted you to look at! Gary> diff --git a/gnulib/aclocal.m4 b/gnulib/aclocal.m4 When I tried this, I saw some of the changes you saw, but not this one. Gary> diff --git a/gnulib/configure b/gnulib/configure Also did not see this one. Did you re-run aclocal and if so did you pass the correct options? That's the only thing I could think of. The other changes look fine. I guess maybe I didn't re-run the autoreconf after some tweak, plus maybe the update script updated the m4 dependencies to be more correct. Tom