From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/symtab] Fix check-psymtab failure for inline function
Date: Mon, 06 Apr 2020 14:40:15 -0600 [thread overview]
Message-ID: <87369gbb68.fsf@tromey.com> (raw)
In-Reply-To: <6d39b3ec-c8f2-ae28-5fa1-caa04c2d75ff@suse.de> (Tom de Vries's message of "Wed, 18 Mar 2020 16:58:22 +0100")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> This patch fixes things in the check itself instead.
Tom> OK for trunk?
Tom> gdb/ChangeLog:
Tom> 2020-03-18 Tom de Vries <tdevries@suse.de>
Tom> * psymtab.c (maintenance_check_psymtabs): Skip static LOC_BLOCK
Tom> symbols without address.
Looks good to me, thanks.
I think the test suite changes are missing a ChangeLog entry.
Tom
prev parent reply other threads:[~2020-04-06 20:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 14:52 Tom de Vries
2020-03-11 0:08 ` Tom Tromey
2020-03-18 13:48 ` [committed][gdb/testsuite] Add test-case gdb.dwarf2/break-inline-psymtab.exp Tom de Vries
2020-04-02 14:24 ` Pedro Alves
2020-04-02 15:14 ` Tom de Vries
2020-03-18 15:58 ` [PATCH][gdb/symtab] Fix check-psymtab failure for inline function Tom de Vries
2020-04-02 8:46 ` [PING][PATCH][gdb/symtab] " Tom de Vries
2020-04-06 20:40 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87369gbb68.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox