From: Tom Tromey <tom@tromey.com>
To: Gary Benson via Gdb-patches <gdb-patches@sourceware.org>
Cc: Andreas Schwab <schwab@linux-m68k.org>
Subject: Re: [PATCH] Fix gdb.dwarf2/clztest.exp with Clang
Date: Mon, 02 Nov 2020 13:25:53 -0700 [thread overview]
Message-ID: <87361rsdym.fsf@tromey.com> (raw)
In-Reply-To: <20201102191402.GA6162@blade.nx> (Gary Benson via Gdb-patches's message of "Mon, 2 Nov 2020 19:14:02 +0000")
>> Shouldn't .eh_frame always be read-only?
Gary> I don't know.
For a test in particular I think the question is whether the change can
somehow negatively affect the test itself; and maybe secondarily whether
some plausible and/or planned future change would break the test.
If not then it seems fine to move forward.
Generally I think we'd be better off eliminating these assembly tests in
favor of something like the test suite's DWARF assembler, though I
didn't look to see whether this one would qualify.
Tom
next prev parent reply other threads:[~2020-11-02 20:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 17:08 Gary Benson via Gdb-patches
2020-11-02 17:52 ` Andreas Schwab
2020-11-02 19:14 ` Gary Benson via Gdb-patches
2020-11-02 19:22 ` Andreas Schwab
2020-11-02 19:31 ` Rainer Orth
2020-11-02 20:30 ` Andreas Schwab
2020-11-02 19:29 ` Rainer Orth
2020-11-02 20:25 ` Tom Tromey [this message]
2020-11-04 11:26 ` [PATCH v2] " Gary Benson via Gdb-patches
2020-11-18 9:20 ` [PING][PATCH " Gary Benson via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87361rsdym.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox