Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Gary Benson via Gdb-patches <gdb-patches@sourceware.org>
To: gdb-patches@sourceware.org
Subject: [PATCH] Fix gdb.dwarf2/clztest.exp with Clang
Date: Mon,  2 Nov 2020 17:08:49 +0000	[thread overview]
Message-ID: <1604336929-1338-1-git-send-email-gbenson@redhat.com> (raw)

Hi all,

Clang fails to compile gdb.dwarf2/clztest.S, with the following error:

  gdb compile failed, /gdbtest/src/gdb/testsuite/gdb.dwarf2/clztest.S:181:2:
    error: changed section flags for .eh_frame, expected: 0x2

This commit fixes the testcase by defining .eh_frame's flags
as Clang expects, when building with Clang (i.e. as "a" rather
than as "aw".)

Checked on Fedora 32 x86_64, with GCC and Clang.  Ok to commit?

Cheers,
Gary

---
gdb/testsuite/ChangeLog:

	* gdb.dwarf2/clztest.S (EH_FRAME_SH_FLAGS): New macro.
	(.eh_frame): Use the above.
---
 gdb/testsuite/ChangeLog            | 5 +++++
 gdb/testsuite/gdb.dwarf2/clztest.S | 8 +++++++-
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.dwarf2/clztest.S b/gdb/testsuite/gdb.dwarf2/clztest.S
index a904fee..08a8bac 100644
--- a/gdb/testsuite/gdb.dwarf2/clztest.S
+++ b/gdb/testsuite/gdb.dwarf2/clztest.S
@@ -22,6 +22,12 @@
 
 */
 
+#if defined(__clang__)
+# define EH_FRAME_SH_FLAGS "a"
+#else
+# define EH_FRAME_SH_FLAGS "aw"
+#endif
+
 	.file	"clztest.c"
 	.text
 .Ltext0:
@@ -178,7 +184,7 @@ _start:
 .LEFDE4:
 #NO_APP
 #APP
-	.section	.eh_frame,"aw",@progbits
+	.section	.eh_frame,EH_FRAME_SH_FLAGS,@progbits
 .Lframe1:
 	.long	.LECIE1-.LSCIE1	# Length of Common Information Entry
 .LSCIE1:
-- 
1.8.3.1


             reply	other threads:[~2020-11-02 17:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-02 17:08 Gary Benson via Gdb-patches [this message]
2020-11-02 17:52 ` Andreas Schwab
2020-11-02 19:14   ` Gary Benson via Gdb-patches
2020-11-02 19:22     ` Andreas Schwab
2020-11-02 19:31       ` Rainer Orth
2020-11-02 20:30         ` Andreas Schwab
2020-11-02 19:29     ` Rainer Orth
2020-11-02 20:25     ` Tom Tromey
2020-11-04 11:26       ` [PATCH v2] " Gary Benson via Gdb-patches
2020-11-18  9:20         ` [PING][PATCH " Gary Benson via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1604336929-1338-1-git-send-email-gbenson@redhat.com \
    --to=gdb-patches@sourceware.org \
    --cc=gbenson@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox