From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PING][PATCH][gdb/symtab] Fix wrong unit_type Dwarf Error
Date: Thu, 25 Feb 2021 07:37:53 -0700 [thread overview]
Message-ID: <8735xkxlfi.fsf@tromey.com> (raw)
In-Reply-To: <7af3f689-ebee-b4d6-fc0e-4c8a54391224@suse.de> (Tom de Vries's message of "Thu, 25 Feb 2021 00:01:40 +0100")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>> Fix this by changing the section_kind argument to create_debug_type_hash_table
>> to rcuh_kind::COMPILE, to reflect that we're passing &dwo_file->sections.info
>> rather than &dwo_file->sections.types.
>>
>> Tested on x86_64-linux.
>>
>> Any comments?
Sorry about dropping this. My only comment is that this code seems
unduly complicated, but at the same time, I didn't feel like trying to
untangle it all.
This is ok.
Tom
prev parent reply other threads:[~2021-02-25 14:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 10:59 [PATCH][gdb/symtab] " Tom de Vries
2021-02-24 23:01 ` [PING][PATCH][gdb/symtab] " Tom de Vries
2021-02-25 14:37 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735xkxlfi.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox