From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 5Py/AGa2N2DENQAAWB0awg (envelope-from ) for ; Thu, 25 Feb 2021 09:38:30 -0500 Received: by simark.ca (Postfix, from userid 112) id F00E01EF78; Thu, 25 Feb 2021 09:38:29 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,RDNS_NONE,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9BC051E789 for ; Thu, 25 Feb 2021 09:38:29 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6068F3890439; Thu, 25 Feb 2021 14:38:29 +0000 (GMT) Received: from gateway24.websitewelcome.com (gateway24.websitewelcome.com [192.185.51.196]) by sourceware.org (Postfix) with ESMTPS id 646043851C3E for ; Thu, 25 Feb 2021 14:38:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 646043851C3E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 38E522FB9F for ; Thu, 25 Feb 2021 08:37:54 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id FHm6lyW7QoE4DFHm6lrxSO; Thu, 25 Feb 2021 08:37:54 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Al7SG8S1f2AAMhM8gwE1k7Uyrs1eosx7+8bjcahGUqY=; b=ec+21ACwPwwa2Dg7S5amG/J8Nu ur5dfwIGEEI6JbBrLbMXVUN6KjVaJRQbPZHQM6swFAUrye9zOeWrUk6Xe/kh02tRK/xzFi0yQ8hKb zU58LddjRo/qtBUNRvsvAg4Br; Received: from 97-122-70-152.hlrn.qwest.net ([97.122.70.152]:45664 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lFHm5-000Oxe-RS; Thu, 25 Feb 2021 07:37:53 -0700 From: Tom Tromey To: Tom de Vries Subject: Re: [PING][PATCH][gdb/symtab] Fix wrong unit_type Dwarf Error References: <20210211105947.GA22976@delia> <7af3f689-ebee-b4d6-fc0e-4c8a54391224@suse.de> X-Attribution: Tom Date: Thu, 25 Feb 2021 07:37:53 -0700 In-Reply-To: <7af3f689-ebee-b4d6-fc0e-4c8a54391224@suse.de> (Tom de Vries's message of "Thu, 25 Feb 2021 00:01:40 +0100") Message-ID: <8735xkxlfi.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.70.152 X-Source-L: No X-Exim-ID: 1lFHm5-000Oxe-RS X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-70-152.hlrn.qwest.net (murgatroyd) [97.122.70.152]:45664 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Tom" == Tom de Vries writes: >> Fix this by changing the section_kind argument to create_debug_type_hash_table >> to rcuh_kind::COMPILE, to reflect that we're passing &dwo_file->sections.info >> rather than &dwo_file->sections.types. >> >> Tested on x86_64-linux. >> >> Any comments? Sorry about dropping this. My only comment is that this code seems unduly complicated, but at the same time, I didn't feel like trying to untangle it all. This is ok. Tom