Re: [PATCH] sim: enable hardware support by default

[Tom Tromey <tom@tromey.com>]

>>>>> "Mike" == Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org> writes:

Mike> Force this on for all ports.  We have a few common models that can
Mike> be used, so make them generally available.  If the port doesn't use
Mike> any hardware (the default), then behavior is unchanged.

I didn't bisect, so I am not completely sure, but some recent patch
(maybe this one) caused:

../../../binutils-gdb/sim/mips/../common/dv-sockser.c:226:1: warning: no previous prototype for ‘dv_sockser_install’ [-Wmissing-prototypes]
  226 | dv_sockser_install (SIM_DESC sd)
      | ^~~~~~~~~~~~~~~~~~
../../../binutils-gdb/sim/mips/../common/dv-sockser.c:287:1: error: redefinition of ‘dv_sockser_status’
  287 | dv_sockser_status (SIM_DESC sd)
      | ^~~~~~~~~~~~~~~~~
In file included from ../../../binutils-gdb/sim/mips/../common/dv-sockser.c:49:
../../../binutils-gdb/sim/mips/../common/dv-sockser.h:44:1: note: previous definition of ‘dv_sockser_status’ was here
   44 | dv_sockser_status (SIM_DESC sd)
      | ^~~~~~~~~~~~~~~~~
../../../binutils-gdb/sim/mips/../common/dv-sockser.c:342:1: error: redefinition of ‘dv_sockser_write_buffer’
  342 | dv_sockser_write_buffer (SIM_DESC sd, const unsigned char *buffer,
      | ^~~~~~~~~~~~~~~~~~~~~~~
In file included from ../../../binutils-gdb/sim/mips/../common/dv-sockser.c:49:
../../../binutils-gdb/sim/mips/../common/dv-sockser.h:58:1: note: previous definition of ‘dv_sockser_write_buffer’ was here
   58 | dv_sockser_write_buffer (SIM_DESC sd, const unsigned char *buffer,
      | ^~~~~~~~~~~~~~~~~~~~~~~
../../../binutils-gdb/sim/mips/../common/dv-sockser.c:365:1: error: redefinition of ‘dv_sockser_write’
  365 | dv_sockser_write (SIM_DESC sd, unsigned char c)
      | ^~~~~~~~~~~~~~~~
In file included from ../../../binutils-gdb/sim/mips/../common/dv-sockser.c:49:
../../../binutils-gdb/sim/mips/../common/dv-sockser.h:52:1: note: previous definition of ‘dv_sockser_write’ was here
   52 | dv_sockser_write (SIM_DESC sd, unsigned char c)
      | ^~~~~~~~~~~~~~~~
../../../binutils-gdb/sim/mips/../common/dv-sockser.c:371:1: error: redefinition of ‘dv_sockser_read’
  371 | dv_sockser_read (SIM_DESC sd)
      | ^~~~~~~~~~~~~~~
In file included from ../../../binutils-gdb/sim/mips/../common/dv-sockser.c:49:
../../../binutils-gdb/sim/mips/../common/dv-sockser.h:65:1: note: previous definition of ‘dv_sockser_read’ was here
   65 | dv_sockser_read (SIM_DESC sd)
      | ^~~~~~~~~~~~~~~
make[3]: *** [Makefile:578: dv-sockser.o] Error 1

thanks,
Tom