From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2HS+Gw+OhGCPMgAAWB0awg (envelope-from ) for ; Sat, 24 Apr 2021 17:30:55 -0400 Received: by simark.ca (Postfix, from userid 112) id 642D71F11C; Sat, 24 Apr 2021 17:30:55 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 68A1F1E01F for ; Sat, 24 Apr 2021 17:30:54 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AF550385E01D; Sat, 24 Apr 2021 21:30:53 +0000 (GMT) Received: from gateway33.websitewelcome.com (gateway33.websitewelcome.com [192.185.146.119]) by sourceware.org (Postfix) with ESMTPS id BFC16385E01D for ; Sat, 24 Apr 2021 21:30:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BFC16385E01D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 71AB22F942 for ; Sat, 24 Apr 2021 16:30:50 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id aPrWl6vtS1cHeaPrWlBotX; Sat, 24 Apr 2021 16:30:50 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ln4WYwZccVZFsK8tkJS/6srSC/OBwmTY14QgZg/s14s=; b=IdFLhtseY/D+BU/PFbPu3zuFer hgwv7j86UKTgd0cAUSzINGvwxP3BvZ8jVeuBGjUlC9qc77Zcj1euYufH7yjv5RooKoqLCeYE801fv X4twBHKHuquFEYxQIQP4oSj0d; Received: from 71-211-182-15.hlrn.qwest.net ([71.211.182.15]:50424 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1laPrW-001sO0-6Y; Sat, 24 Apr 2021 15:30:50 -0600 From: Tom Tromey To: Mike Frysinger via Gdb-patches Subject: Re: [PATCH] sim: enable hardware support by default References: <20210424041958.12761-1-vapier@gentoo.org> X-Attribution: Tom Date: Sat, 24 Apr 2021 15:30:49 -0600 In-Reply-To: <20210424041958.12761-1-vapier@gentoo.org> (Mike Frysinger via Gdb-patches's message of "Sat, 24 Apr 2021 00:19:58 -0400") Message-ID: <8735vfe5fa.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.182.15 X-Source-L: No X-Exim-ID: 1laPrW-001sO0-6Y X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-182-15.hlrn.qwest.net (localhost.localdomain) [71.211.182.15]:50424 X-Source-Auth: tom+tromey.com X-Email-Count: 14 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: joel@rtems.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Mike" =3D=3D Mike Frysinger via Gdb-patches writes: Mike> Force this on for all ports. We have a few common models that can Mike> be used, so make them generally available. If the port doesn't use Mike> any hardware (the default), then behavior is unchanged. I didn't bisect, so I am not completely sure, but some recent patch (maybe this one) caused: ../../../binutils-gdb/sim/mips/../common/dv-sockser.c:226:1: warning: no pr= evious prototype for =E2=80=98dv_sockser_install=E2=80=99 [-Wmissing-protot= ypes] 226 | dv_sockser_install (SIM_DESC sd) | ^~~~~~~~~~~~~~~~~~ ../../../binutils-gdb/sim/mips/../common/dv-sockser.c:287:1: error: redefin= ition of =E2=80=98dv_sockser_status=E2=80=99 287 | dv_sockser_status (SIM_DESC sd) | ^~~~~~~~~~~~~~~~~ In file included from ../../../binutils-gdb/sim/mips/../common/dv-sockser.c= :49: ../../../binutils-gdb/sim/mips/../common/dv-sockser.h:44:1: note: previous = definition of =E2=80=98dv_sockser_status=E2=80=99 was here 44 | dv_sockser_status (SIM_DESC sd) | ^~~~~~~~~~~~~~~~~ ../../../binutils-gdb/sim/mips/../common/dv-sockser.c:342:1: error: redefin= ition of =E2=80=98dv_sockser_write_buffer=E2=80=99 342 | dv_sockser_write_buffer (SIM_DESC sd, const unsigned char *buffer, | ^~~~~~~~~~~~~~~~~~~~~~~ In file included from ../../../binutils-gdb/sim/mips/../common/dv-sockser.c= :49: ../../../binutils-gdb/sim/mips/../common/dv-sockser.h:58:1: note: previous = definition of =E2=80=98dv_sockser_write_buffer=E2=80=99 was here 58 | dv_sockser_write_buffer (SIM_DESC sd, const unsigned char *buffer, | ^~~~~~~~~~~~~~~~~~~~~~~ ../../../binutils-gdb/sim/mips/../common/dv-sockser.c:365:1: error: redefin= ition of =E2=80=98dv_sockser_write=E2=80=99 365 | dv_sockser_write (SIM_DESC sd, unsigned char c) | ^~~~~~~~~~~~~~~~ In file included from ../../../binutils-gdb/sim/mips/../common/dv-sockser.c= :49: ../../../binutils-gdb/sim/mips/../common/dv-sockser.h:52:1: note: previous = definition of =E2=80=98dv_sockser_write=E2=80=99 was here 52 | dv_sockser_write (SIM_DESC sd, unsigned char c) | ^~~~~~~~~~~~~~~~ ../../../binutils-gdb/sim/mips/../common/dv-sockser.c:371:1: error: redefin= ition of =E2=80=98dv_sockser_read=E2=80=99 371 | dv_sockser_read (SIM_DESC sd) | ^~~~~~~~~~~~~~~ In file included from ../../../binutils-gdb/sim/mips/../common/dv-sockser.c= :49: ../../../binutils-gdb/sim/mips/../common/dv-sockser.h:65:1: note: previous = definition of =E2=80=98dv_sockser_read=E2=80=99 was here 65 | dv_sockser_read (SIM_DESC sd) | ^~~~~~~~~~~~~~~ make[3]: *** [Makefile:578: dv-sockser.o] Error 1 thanks, Tom