From: Tom Tromey <tromey@redhat.com>
To: dje@google.com (Doug Evans)
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA libiberty, gdb] Add hashtab support to filename_ncmp.c and use it in gdb.
Date: Tue, 10 Jul 2012 19:17:00 -0000 [thread overview]
Message-ID: <871ukjh1e1.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20120709181407.213E81E13A1@ruffy2.mtv.corp.google.com> (Doug Evans's message of "Mon, 9 Jul 2012 11:14:07 -0700 (PDT)")
>>>>> "Doug" == Doug Evans <dje@google.com> writes:
Doug> filename_seen in gdb does a linear search, this patch changes it
Doug> to use a hash table.
Doug> Ok to check in?
The gdb parts look good to me.
Doug> I couldn't think of a good reason to put filename_hash,filename_eq
Doug> in gdb, and I like placing them close to where hashtab.c and
Doug> filename_cmp are defined. I also couldn't think of a sufficient
Doug> reason to put them in a file by themselves.
FWIW, I agree. I'd like to see this patch go in.
Tom
next prev parent reply other threads:[~2012-07-10 19:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-09 18:14 Doug Evans
2012-07-10 19:17 ` Tom Tromey [this message]
[not found] <20120709181015.2FCA41E13A1@ruffy2.mtv.corp.google.com>
[not found] ` <CABu31nPhJ_3+yCNCArF7P3+Z+13cXVSoTqUyn1rKKQXv4+oVUA@mail.gmail.com>
2012-07-09 19:49 ` Doug Evans
2012-07-13 18:52 ` Doug Evans
2012-07-13 19:22 ` DJ Delorie
2012-07-13 19:37 ` Doug Evans
2012-07-13 19:46 ` DJ Delorie
2012-07-13 19:48 ` Eli Zaretskii
2012-07-13 21:26 ` Doug Evans
2012-07-14 6:34 ` Eli Zaretskii
[not found] ` <831ukeam18.fsf__35820.0409253643$1342247693$gmane$org@gnu.org>
2012-07-15 2:18 ` Tom Tromey
2012-07-14 0:07 ` Doug Evans
2012-07-14 1:59 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871ukjh1e1.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox