From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24137 invoked by alias); 10 Jul 2012 19:17:32 -0000 Received: (qmail 24127 invoked by uid 22791); 10 Jul 2012 19:17:31 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 10 Jul 2012 19:17:13 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6AJHBZZ003429 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 10 Jul 2012 15:17:11 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q6AJHA3f014484 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 10 Jul 2012 15:17:11 -0400 From: Tom Tromey To: dje@google.com (Doug Evans) Cc: gdb-patches@sourceware.org Subject: Re: [RFA libiberty, gdb] Add hashtab support to filename_ncmp.c and use it in gdb. References: <20120709181407.213E81E13A1@ruffy2.mtv.corp.google.com> Date: Tue, 10 Jul 2012 19:17:00 -0000 In-Reply-To: <20120709181407.213E81E13A1@ruffy2.mtv.corp.google.com> (Doug Evans's message of "Mon, 9 Jul 2012 11:14:07 -0700 (PDT)") Message-ID: <871ukjh1e1.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00139.txt.bz2 >>>>> "Doug" == Doug Evans writes: Doug> filename_seen in gdb does a linear search, this patch changes it Doug> to use a hash table. Doug> Ok to check in? The gdb parts look good to me. Doug> I couldn't think of a good reason to put filename_hash,filename_eq Doug> in gdb, and I like placing them close to where hashtab.c and Doug> filename_cmp are defined. I also couldn't think of a sufficient Doug> reason to put them in a file by themselves. FWIW, I agree. I'd like to see this patch go in. Tom