From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/6] attach to command_option-changed observer.
Date: Fri, 27 Jul 2012 17:20:00 -0000 [thread overview]
Message-ID: <871ujxce9i.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1343402543-665-3-git-send-email-yao@codesourcery.com> (Yao Qi's message of "Fri, 27 Jul 2012 23:22:19 +0800")
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> +@item =option-changed,option=@var{option},value=@var{value}
Yao> +Reports that an option of the command @code{set @var{option}} is
Yao> +changed to @var{value}.
I think it would be useful to MI client authors if this were a bit more
specific; in particular describing what happens for a multi-word "set"
command like "set print elements 5".
Yao> + ui_out_redirect (mi_uiout, mi->event_channel);
Yao> + ui_out_field_string (mi_uiout, "option", option);
Yao> + ui_out_field_string (mi_uiout, "value", value);
Yao> + ui_out_redirect (mi_uiout, NULL);
Nice and simple :-)
Yao> + /* Breakpoint notification suppressed? */
Yao> + int breakpoint;
Yao> + /* Command option changed notification suppressed? */
Yao> + int option_changed;
Two spaces after the "?"s.
Tom
next prev parent reply other threads:[~2012-07-27 17:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-27 15:23 [RCF 0/6 V2] MI notification of command option change Yao Qi
2012-07-27 15:23 ` [PATCH 3/6] notify in enum_cmd and scheduler-locking Yao Qi
2012-07-27 15:23 ` [PATCH 6/6] code indentation Yao Qi
2012-07-27 15:23 ` [PATCH 2/6] attach to command_option-changed observer Yao Qi
2012-07-27 17:20 ` Tom Tromey [this message]
2012-07-27 17:44 ` Tom Tromey
2012-07-27 15:23 ` [PATCH 4/6] notify in boolean_cmd and circular-trace-buffer Yao Qi
2012-07-27 15:23 ` [PATCH 5/6] notify in string_cmd and trace-notes Yao Qi
2012-07-27 15:23 ` [PATCH 1/6] new observer command_option_changed Yao Qi
2012-07-27 17:56 ` Tom Tromey
2012-07-27 17:07 ` [RCF 0/6 V2] MI notification of command option change Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871ujxce9i.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox