From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-93244-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 8063 invoked by alias); 27 Jul 2012 17:20:36 -0000
Received: (qmail 7997 invoked by uid 22791); 27 Jul 2012 17:20:31 -0000
X-SWARE-Spam-Status: No, hits=-6.5 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 Jul 2012 17:20:14 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6RHKBZA000954	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 27 Jul 2012 13:20:11 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q6RHK9nb017787	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Fri, 27 Jul 2012 13:20:10 -0400
From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/6] attach to command_option-changed observer.
References: <1343402543-665-1-git-send-email-yao@codesourcery.com>	<1343402543-665-3-git-send-email-yao@codesourcery.com>
Date: Fri, 27 Jul 2012 17:20:00 -0000
In-Reply-To: <1343402543-665-3-git-send-email-yao@codesourcery.com> (Yao Qi's	message of "Fri, 27 Jul 2012 23:22:19 +0800")
Message-ID: <871ujxce9i.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-07/txt/msg00700.txt.bz2

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> +@item =option-changed,option=@var{option},value=@var{value}
Yao> +Reports that an option of the command @code{set @var{option}} is
Yao> +changed to @var{value}.

I think it would be useful to MI client authors if this were a bit more
specific; in particular describing what happens for a multi-word "set"
command like "set print elements 5".

Yao> +  ui_out_redirect (mi_uiout, mi->event_channel);
Yao> +  ui_out_field_string (mi_uiout, "option", option);
Yao> +  ui_out_field_string (mi_uiout, "value", value);
Yao> +  ui_out_redirect (mi_uiout, NULL);

Nice and simple :-)

Yao> +  /* Breakpoint notification suppressed? */
Yao> +  int breakpoint;
Yao> +  /* Command option changed notification suppressed? */
Yao> +  int option_changed;

Two spaces after the "?"s.

Tom