Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 3/3] Match output in async mode.
Date: Tue, 30 Jul 2013 20:06:00 -0000	[thread overview]
Message-ID: <871u6flsmp.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1337939766-1579-4-git-send-email-yao@codesourcery.com> (Yao Qi's	message of "Fri, 25 May 2012 17:56:06 +0800")

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> This patch is to match the program's output when in async mode.  It is
Yao> hard to match output in a unique way to handle both sync mode and
Yao> async mode, so I have to handle them separately.

Yao> The reason I choose send_gdb/gdb_expect, instead of gdb_test_multiple,
Yao> is gdb_test_multiple matches ""\r\n$gdb_prompt $", and return false.
Yao> However, "(gdb) " may appear in somewhere in the output, and trigger
Yao> fail for test.

I don't understand the need for this patch.
It seems to me that everything in this test case is async.
The setting of "target-async" therefore should not matter -- with
target-async enabled (either explicitly in today's gdb, or implicitly
after my patch series), sync commands should work exactly as they would
in the "async disabled" gdb.

Tom


  reply	other threads:[~2013-07-30 20:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-25  9:56 Fix PR14135 Yao Qi
2012-05-25  9:56 ` [PATCH 3/3] Match output in async mode Yao Qi
2013-07-30 20:06   ` Tom Tromey [this message]
2013-07-31  7:45     ` Yao Qi
2012-05-25  9:56 ` [PATCH 1/3] New test case for PR12929 Yao Qi
2013-07-30 19:49   ` Tom Tromey
2013-07-30 20:11     ` Tom Tromey
2013-07-31  7:53     ` Yao Qi
2013-07-31 15:19       ` Tom Tromey
2013-08-01  6:39         ` Yao Qi
2012-05-25  9:56 ` [PATCH 2/3] Don't force interpreter sync mode in execute_gdb_command Yao Qi
2013-07-30 19:55   ` Tom Tromey
2013-07-30 20:13     ` Tom Tromey
2012-07-17  2:51 ` Fix PR14135 Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871u6flsmp.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox