From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17400 invoked by alias); 30 Jul 2013 20:06:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17391 invoked by uid 89); 30 Jul 2013 20:06:48 -0000 X-Spam-SWARE-Status: No, score=-5.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 30 Jul 2013 20:06:48 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6UK6dTv008218 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 30 Jul 2013 16:06:40 -0400 Received: from barimba (ovpn-113-128.phx2.redhat.com [10.3.113.128]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r6UK6cBP030235 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 30 Jul 2013 16:06:39 -0400 From: Tom Tromey To: Yao Qi Cc: Subject: Re: [PATCH 3/3] Match output in async mode. References: <1337939766-1579-1-git-send-email-yao@codesourcery.com> <1337939766-1579-4-git-send-email-yao@codesourcery.com> Date: Tue, 30 Jul 2013 20:06:00 -0000 In-Reply-To: <1337939766-1579-4-git-send-email-yao@codesourcery.com> (Yao Qi's message of "Fri, 25 May 2012 17:56:06 +0800") Message-ID: <871u6flsmp.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-07/txt/msg00797.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> This patch is to match the program's output when in async mode. It is Yao> hard to match output in a unique way to handle both sync mode and Yao> async mode, so I have to handle them separately. Yao> The reason I choose send_gdb/gdb_expect, instead of gdb_test_multiple, Yao> is gdb_test_multiple matches ""\r\n$gdb_prompt $", and return false. Yao> However, "(gdb) " may appear in somewhere in the output, and trigger Yao> fail for test. I don't understand the need for this patch. It seems to me that everything in this test case is async. The setting of "target-async" therefore should not matter -- with target-async enabled (either explicitly in today's gdb, or implicitly after my patch series), sync commands should work exactly as they would in the "async disabled" gdb. Tom