From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org, Muhammad Waqas <mwaqas@codesourcery.com>
Subject: Re: [PATCH] PR gdb/11568 - delete thread-specific breakpoints on thread exit
Date: Mon, 09 Sep 2013 16:07:00 -0000 [thread overview]
Message-ID: <871u4ykmgq.fsf@fleche.redhat.com> (raw)
In-Reply-To: <5224C238.2060106@redhat.com> (Pedro Alves's message of "Mon, 02 Sep 2013 17:52:08 +0100")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> Here it is. Let me know what you all think.
It looks good to me.
Pedro> There's no way that breakpoint can trigger again (*), so the PR argues
Pedro> that the breakpoint should just be removed, like local watchpoints.
Pedro> I'm ambivalent on this -- it could be reasonable to disable the
Pedro> breakpoint (kind of like breakpoint in shared library code when the
Pedro> DSO is unloaded), so the user could still use it as visual template
Pedro> for creating other breakpoints (copy/paste command lists, etc.), or we
Pedro> could have a way to change to which thread a breakpoint applies. But,
Pedro> several people pushed this direction, and I don't plan on arguing...
I've sometimes wished for a way to modify a breakpoint in place.
There may be another PR about this.
But it's fine to put in this patch now and remove it again later if
anyone actually implements breakpoint modification.
Tom
next prev parent reply other threads:[~2013-09-09 16:07 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 7:29 [PATCH with testcase] Bug 11568 - delete thread-specific breakpoint on the " Muhammad Waqas
2013-07-29 9:21 ` Yao Qi
2013-07-29 11:42 ` Muhammad Waqas
2013-07-29 14:18 ` Yao Qi
2013-07-30 10:34 ` Muhammad Waqas
2013-07-31 2:41 ` Yao Qi
2013-08-01 10:51 ` Pedro Alves
2013-08-01 10:59 ` Yao Qi
2013-08-01 11:27 ` Pedro Alves
2013-08-01 12:10 ` Yao Qi
2013-08-01 11:57 ` Pedro Alves
2013-08-01 12:44 ` Muhammad Waqas
2013-08-02 9:45 ` Pedro Alves
2013-08-05 12:01 ` Muhammad Waqas
2013-08-05 13:57 ` Tom Tromey
2013-08-06 6:12 ` Muhammad Waqas
2013-08-22 9:42 ` Muhammad Waqas
2013-08-22 17:14 ` Pedro Alves
2013-08-23 5:31 ` Muhammad Waqas
2013-08-27 11:31 ` Muhammad Waqas
2013-08-27 19:02 ` Pedro Alves
2013-08-27 19:06 ` Pedro Alves
2013-08-28 12:26 ` Muhammad Waqas
2013-08-30 16:28 ` Pedro Alves
2013-09-02 4:06 ` Muhammad Waqas
2013-09-02 8:39 ` Pedro Alves
2013-09-02 9:46 ` Muhammad Waqas
2013-09-02 10:24 ` Pedro Alves
2013-09-02 10:32 ` Muhammad Waqas
2013-09-02 10:48 ` Pedro Alves
2013-09-02 16:46 ` Pedro Alves
2013-09-02 16:52 ` [PATCH] PR gdb/11568 - delete thread-specific breakpoints on " Pedro Alves
2013-09-09 16:07 ` Tom Tromey [this message]
2013-09-17 19:36 ` Pedro Alves
2013-09-19 14:48 ` [COMMIT PATCH] Fix regressions caused by thread-specific breakpoint deletion. (was: Re: [PATCH] PR gdb/11568 - delete thread-specific breakpoints on thread exit) Pedro Alves
2013-08-28 12:26 ` [PATCH with testcase] Bug 11568 - delete thread-specific breakpoint on the thread exit Muhammad Waqas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871u4ykmgq.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=mwaqas@codesourcery.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox