From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Remove global traceframe_fun and traceframe_sal
Date: Thu, 24 Oct 2013 17:19:00 -0000 [thread overview]
Message-ID: <871u3abn7y.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1382623173-17782-1-git-send-email-yao@codesourcery.com> (Yao Qi's message of "Thu, 24 Oct 2013 21:59:33 +0800")
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> I happen to see traceframe_fun and traceframe_sal are static
Yao> variables, which are not necessary to me. They are only used in
Yao> set_traceframe_context, and they are not stateful. This patch is
Yao> to remove them.
Yao> 2013-10-24 Yao Qi <yao@codesourcery.com>
Yao> * tracepoint.c (traceframe_fun): Remove.
Yao> (traceframe_sal): Remove.
Yao> (set_traceframe_context): Add local variables.
This is ok.
Tom
prev parent reply other threads:[~2013-10-24 17:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 14:01 Yao Qi
2013-10-24 16:44 ` Pedro Alves
2013-10-25 7:09 ` Yao Qi
2013-10-24 17:19 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871u3abn7y.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox