From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25082 invoked by alias); 24 Oct 2013 17:19:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24997 invoked by uid 89); 24 Oct 2013 17:19:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 24 Oct 2013 17:19:49 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9OHJl1B000808 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 24 Oct 2013 13:19:47 -0400 Received: from barimba (ovpn-113-54.phx2.redhat.com [10.3.113.54]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r9OHJkKp012219 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 24 Oct 2013 13:19:46 -0400 From: Tom Tromey To: Yao Qi Cc: Subject: Re: [PATCH] Remove global traceframe_fun and traceframe_sal References: <1382623173-17782-1-git-send-email-yao@codesourcery.com> Date: Thu, 24 Oct 2013 17:19:00 -0000 In-Reply-To: <1382623173-17782-1-git-send-email-yao@codesourcery.com> (Yao Qi's message of "Thu, 24 Oct 2013 21:59:33 +0800") Message-ID: <871u3abn7y.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-10/txt/msg00763.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> I happen to see traceframe_fun and traceframe_sal are static Yao> variables, which are not necessary to me. They are only used in Yao> set_traceframe_context, and they are not stateful. This patch is Yao> to remove them. Yao> 2013-10-24 Yao Qi Yao> * tracepoint.c (traceframe_fun): Remove. Yao> (traceframe_sal): Remove. Yao> (set_traceframe_context): Add local variables. This is ok. Tom