From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Iain Buclaw <ibuclaw@gdcproject.org>
Cc: Keith Seitz <keiths@redhat.com>,
GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH/obv] Rename `typename' in d-exp.y to avoid C++ reserved word
Date: Sun, 16 Aug 2015 13:12:00 -0000 [thread overview]
Message-ID: <871tf3n50r.fsf@redhat.com> (raw)
In-Reply-To: <CABOHX+dQwxbQGqWVzgy7M3oU=1MjH0nwvqg=8qL+x1m-pGOQLA@mail.gmail.com> (Iain Buclaw's message of "Sat, 15 Aug 2015 08:52:38 +0200")
On Saturday, August 15 2015, Iain Buclaw wrote:
> On 15 August 2015 at 02:36, Keith Seitz <keiths@redhat.com> wrote:
>> A recent patch introduced a variable named `typename' into d-exp.y,
>> and one of the --enable-with-cxx build slaves consequently failed to compile
>> this. This patch simply adds an underscore into the name to avoid the
>> reserved word.
>>
>
> I'll have to remember to add that to my own builds, thanks.
Good idea, but if you forget, there's a builder in our BuildBot
dedicated only to catch failures when compiling with --enable-with-cxx.
If something fails, the author will be notified via e-mail.
Of course it's always good to check before pushing the changes, but I
thought it was worth mentioning the builder just in case.
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
prev parent reply other threads:[~2015-08-16 13:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-15 0:36 Keith Seitz
2015-08-15 6:52 ` Iain Buclaw
2015-08-16 13:12 ` Sergio Durigan Junior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871tf3n50r.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=ibuclaw@gdcproject.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox