From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80071 invoked by alias); 16 Aug 2015 13:12:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 80056 invoked by uid 89); 16 Aug 2015 13:12:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sun, 16 Aug 2015 13:12:40 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 1A8448EB39; Sun, 16 Aug 2015 06:04:06 +0000 (UTC) Received: from localhost (unused-10-15-17-51.yyz.redhat.com [10.15.17.51]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t7G645pv025371 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 16 Aug 2015 02:04:05 -0400 From: Sergio Durigan Junior To: Iain Buclaw Cc: Keith Seitz , GDB Patches Subject: Re: [PATCH/obv] Rename `typename' in d-exp.y to avoid C++ reserved word References: <1439598962-32364-1-git-send-email-keiths@redhat.com> X-URL: http://blog.sergiodj.net Date: Sun, 16 Aug 2015 13:12:00 -0000 In-Reply-To: (Iain Buclaw's message of "Sat, 15 Aug 2015 08:52:38 +0200") Message-ID: <871tf3n50r.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00406.txt.bz2 On Saturday, August 15 2015, Iain Buclaw wrote: > On 15 August 2015 at 02:36, Keith Seitz wrote: >> A recent patch introduced a variable named `typename' into d-exp.y, >> and one of the --enable-with-cxx build slaves consequently failed to compile >> this. This patch simply adds an underscore into the name to avoid the >> reserved word. >> > > I'll have to remember to add that to my own builds, thanks. Good idea, but if you forget, there's a builder in our BuildBot dedicated only to catch failures when compiling with --enable-with-cxx. If something fails, the author will be notified via e-mail. Of course it's always good to check before pushing the changes, but I thought it was worth mentioning the builder just in case. -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/