From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <palves@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] Fix crash in "run" on macOS when gdb is not signed
Date: Wed, 04 Jul 2018 17:34:00 -0000 [thread overview]
Message-ID: <871sciq506.fsf@tromey.com> (raw)
In-Reply-To: <0f00199a-cb50-83e0-f0ed-6704fecd76b8@redhat.com> (Pedro Alves's message of "Wed, 4 Jul 2018 12:46:31 +0100")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> Hi Tom, I happened to notice that you pushed the wrong version of
Pedro> the patch.
Oops, sorry about that.
I'm checking in the appended.
Tom
commit a7d0f0f000b39269c25509a22a12549c6ef26b1f
Author: Tom Tromey <tom@tromey.com>
Date: Wed Jul 4 11:32:50 2018 -0600
Use exit_inferior in darwin_attach_pid
Commit a50c11c666 was intended to use exit_inferior in
darwin_attach_pid, but I accidentally pushed the wrong version of the
patch. This fixes the problem.
gdb/ChangeLog
2018-07-04 Tom Tromey <tom@tromey.com>
* darwin-nat.c (darwin_attach_pid): Use exit_inferior.
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index d2319c06d52..7bd0cc4f95e 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2018-07-04 Tom Tromey <tom@tromey.com>
+
+ * darwin-nat.c (darwin_attach_pid): Use exit_inferior.
+
2018-07-04 Simon Marchi <simon.marchi@polymtl.ca>
* common/common-defs.h (HAVE_USEFUL_SBRK): Define.
diff --git a/gdb/darwin-nat.c b/gdb/darwin-nat.c
index 8104de53e7f..5aed285ad46 100644
--- a/gdb/darwin-nat.c
+++ b/gdb/darwin-nat.c
@@ -1662,8 +1662,7 @@ darwin_attach_pid (struct inferior *inf)
}
CATCH (ex, RETURN_MASK_ALL)
{
- inf->pid = 0;
- inf->priv.reset ();
+ exit_inferior (inf);
inferior_ptid = null_ptid;
throw_exception (ex);
prev parent reply other threads:[~2018-07-04 17:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 18:03 Tom Tromey
2018-06-29 19:31 ` Pedro Alves
2018-07-02 15:33 ` Tom Tromey
2018-07-03 14:16 ` Pedro Alves
2018-07-04 11:46 ` Pedro Alves
2018-07-04 17:34 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871sciq506.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox