From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Tom Tromey <tom@tromey.com>,
Simon Marchi <simon.marchi@ericsson.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH] Check return value of bfd_init
Date: Fri, 26 Oct 2018 19:48:00 -0000 [thread overview]
Message-ID: <871s8cij6c.fsf@tromey.com> (raw)
In-Reply-To: <4f3a2fce7baa5ee639c8ae514db50552@polymtl.ca> (Simon Marchi's message of "Fri, 26 Oct 2018 14:31:02 -0400")
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
Simon> The comparison operator is the wrong one (== instead of !=), you
Simon> probably left it like this after testing. LGTM with that fixed.
This patch is cursed.
Tom
prev parent reply other threads:[~2018-10-26 19:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 15:03 Tom Tromey
2018-10-25 15:25 ` Simon Marchi
[not found] ` <87efcehwlx.fsf@tromey.com>
2018-10-26 15:41 ` Tom Tromey
2018-10-26 18:31 ` Simon Marchi
2018-10-26 19:48 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871s8cij6c.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox