From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38403 invoked by alias); 26 Oct 2018 19:48:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 38291 invoked by uid 89); 26 Oct 2018 19:48:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.45.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 26 Oct 2018 19:47:58 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 1F79F400CA703 for ; Fri, 26 Oct 2018 14:47:57 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id G85NgjxMfBcCXG85Ngxu10; Fri, 26 Oct 2018 14:47:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gNQOf7+GJZTjVeJJx+babaXBodwCML608iDlxU8qS20=; b=boZXjCDV6wgHbgQm+aae4llWSO J1Skz0bu06BbFQG6G800HgJo0c1MW7zslGv8n7JphXEqnqkyZDQOUNhhllAoBZf1BdrEmTuWMLmq5 AtvftoYQNpxP6zPyEDon/TgiQ; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:44992 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gG85M-000dHV-Qj; Fri, 26 Oct 2018 14:47:56 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] Check return value of bfd_init References: <20181025150340.28844-1-tom@tromey.com> <87efcehwlx.fsf@tromey.com> <875zxoiulq.fsf@tromey.com> <4f3a2fce7baa5ee639c8ae514db50552@polymtl.ca> Date: Fri, 26 Oct 2018 19:48:00 -0000 In-Reply-To: <4f3a2fce7baa5ee639c8ae514db50552@polymtl.ca> (Simon Marchi's message of "Fri, 26 Oct 2018 14:31:02 -0400") Message-ID: <871s8cij6c.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-10/txt/msg00634.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> The comparison operator is the wrong one (== instead of !=), you Simon> probably left it like this after testing. LGTM with that fixed. This patch is cursed. Tom