Re: buildbot config cc-with-index not functional

[Sergio Durigan Junior <sergiodj@redhat.com>]

On Monday, May 13 2019, Tom de Vries wrote:

> On 03-05-19 22:50, Sergio Durigan Junior wrote:
>> On Friday, May 03 2019, Tom de Vries wrote:
>> 
>>> On 03-05-19 21:47, Sergio Durigan Junior wrote:
>>>> On Friday, May 03 2019, Tom de Vries wrote:
>>>>
>>>>> [ was: Re: [committed][gdb/testsuite] Add cc-with-gdb-index.exp ]
>>>>>
>>>>> Hi,
>>>>>
>>>>> I've just added a target board cc-with-gdb-index.exp, to make it easy to
>>>>> test using cc-with-tweaks.sh -i.
>>>>>
>>>>> Then I stumbled upon the build bot config Fedora-x86_64-cc-with-index,
>>>>> and I took a look at the test results.
>>>>>
>>>>> I noticed that a test failing with cc-with-gdb-index.exp,
>>>>> gdb.base/cache-index.exp (see PR24516 - "cc-with-gdb-index failures") is
>>>>> passing in the cc-with-index config.
>>>>>
>>>>> I managed to reproduce that pass using the way the config uses
>>>>> cc-with-tweaks.sh:
>>>>> ...
>>>>> $ make -k check \
>>>>>   'CC_FOR_TARGET=/bin/sh gdb/contrib/cc-with-tweaks.sh -i gcc' \
>>>>>   'CXX_FOR_TARGET=/bin/sh gdb/contrib/cc-with-tweaks.sh -i g++' \
>>>>>   -j4 \
>>>>>   FORCE_PARALLEL=1 \
>>>>>   TS=1
>>>>> ...
>>>>>
>>>>> So, AFAIU, the cc-with-index buildbot config does not actually test
>>>>> using cc-with-tweaks.sh -i, as it intends to.
>>>>
>>>> Ah...  Thanks for bringing this up.  IIUC, CC_FOR_TARGET and
>>>> CXX_FOR_TARGET need to be passed inside RUNTESTFLAGS.  I think that's
>>>> the problem.  Can you please check if you can reproduce the bug when you
>>>> do that?
>>>>
>>>
>>> Confirmed, using:
>>> ...
>>> $ make -k check "RUNTESTFLAGS='CC_FOR_TARGET=/bin/sh
>>> $pwd/gdb/contrib/cc-with-tweaks.sh -i gcc' 'CXX_FOR_TARGET=/bin/sh
>>> $pwd/gdb/contrib/cc-with-tweaks.sh -i g++' gdb.base/index-cache.exp"
>>> ...
>>> I can reproduce the bug.
>> 
>> Thanks.
>> 
>>>> Also, I'm happy to know there's now a cc-with-gdb-index.exp flag.  So the
>>>> buildbot can just use RUNTESTFLAGS='--target_board
>>>> cc-with-gdb-index.exp', right?
>>>>
>>>
>>> Yep, that's the idea.
>> 
>> Thanks, I'll update the config file now.
>> 
>
> Hi,
>
> things still seem to be failing (
> https://gdb-build.sergiodj.net/builders/Fedora-x86_64-cc-with-index/builds/12689/steps/test%20gdb/logs/stdio
> ):
> ...
> make -k check 'RUNTESTFLAGS=CC_FOR_TARGET="/bin/sh
> /home/gdb-buildbot/fedora-x86-64-3/fedora-x86-64-cc-with-index/binutils-gdb/gdb/contrib/cc-with-tweaks.sh
> -i gcc" CXX_FOR_TARGET="/bin/sh
> /home/gdb-buildbot/fedora-x86-64-3/fedora-x86-64-cc-with-index/binutils-gdb/gdb/contrib/cc-with-tweaks.sh
> -i g++"' -j4 FORCE_PARALLEL=1 TS=1
>    ...
> make[1]: *** No rule to make target 'gcc CXX_FOR_TARGET=/bin/sh'.
> make[1]: *** No rule to make target 'g++'.
> ...
> ?

Sorry, it's taken longer than I expected to get back to this, and then I
had to struggle with quoting and argument-passing.  Anyway, I think I
figured it out now.  Here's an example of the log file generated:

  https://gdb-build.sergiodj.net/results/Fedora-x86_64-cc-with-index/e6/e6f65e7573a317ac4efff26fe0e49fe1b9e7a596/gdb.log.xz

I'm still seeing a lot of "ERROR" messages, though:

  https://gdb-build.sergiodj.net/builders/Fedora-x86_64-cc-with-index/builds/12827/steps/test%20gdb/logs/stdio

I don't know if that's something related to the buildslave, or to
something else.

Anyway, can you double check to see if I didn't forget something,
please?

Thanks!

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/