From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <palves@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v3 4/8] Lock the demangled hash table
Date: Thu, 30 May 2019 21:58:00 -0000 [thread overview]
Message-ID: <871s0fehak.fsf@tromey.com> (raw)
In-Reply-To: <25f1c05d-c2ef-d229-1eef-1029186070b3@redhat.com> (Pedro Alves's message of "Thu, 30 May 2019 13:58:49 +0100")
>> This introduces a lock that is used when modifying the demangled hash
>> table.
Pedro> There's only a single mutex, and the comment says _THE_ demangled
Pedro> hash table, but AFAICS, each per_bfd has its own table, right?
Yes, that's correct. I'll fix the comment.
Pedro> A single lock for every table compared to a lock per table might be
Pedro> a good approach, but I'd welcome extended comments to explain
Pedro> that design choice.
I didn't want to put a mutex into the per-bfd object, mostly because it
uses space for the entire lifetime of that, while the mutex is only used
while demangling minsym names; and that can (currently) only be done for
one objfile at a time.
Tom
next prev parent reply other threads:[~2019-05-30 21:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 21:29 [PATCH v3 0/8] Demangle minimal symbol names in worker threads Tom Tromey
2019-05-29 21:29 ` [PATCH v3 1/8] Defer minimal symbol name-setting Tom Tromey
2019-05-29 21:29 ` [PATCH v3 3/8] Add configure check for std::thread Tom Tromey
2019-05-30 11:34 ` Pedro Alves
2019-05-29 21:29 ` [PATCH v3 2/8] Remove static buffer from ada_decode Tom Tromey
2019-05-30 0:08 ` Pedro Alves
2019-05-29 21:29 ` [PATCH v3 4/8] Lock the demangled hash table Tom Tromey
2019-05-30 12:58 ` Pedro Alves
2019-05-30 14:03 ` Pedro Alves
2019-05-30 21:58 ` Tom Tromey [this message]
2019-05-29 21:29 ` [PATCH v3 8/8] Add maint set/show max-worker-threads Tom Tromey
2019-05-30 2:36 ` Eli Zaretskii
2019-05-30 14:20 ` Pedro Alves
2019-05-29 21:29 ` [PATCH v3 5/8] Introduce run_on_main_thread Tom Tromey
2019-05-30 13:12 ` Pedro Alves
2019-05-30 13:20 ` Tom Tromey
2019-05-30 13:57 ` Pedro Alves
2019-05-30 14:01 ` Pedro Alves
2019-05-29 21:29 ` [PATCH v3 7/8] Demangle minsyms in parallel Tom Tromey
2019-05-30 14:19 ` Pedro Alves
2019-05-30 22:22 ` Tom Tromey
2019-05-29 22:03 ` [PATCH v3 6/8] Introduce thread-safe way to handle SIGSEGV Tom Tromey
2019-05-30 13:40 ` Pedro Alves
2019-06-09 15:43 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871s0fehak.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox