From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22570 invoked by alias); 30 May 2019 21:58:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22562 invoked by uid 89); 30 May 2019 21:58:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=explain X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.45.163) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 30 May 2019 21:58:14 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 2A86440122291 for ; Thu, 30 May 2019 16:58:13 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id WT3thARCX2PzOWT3thWMUi; Thu, 30 May 2019 16:58:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=K8DW87dADz6PQi6kBR0od6ojIW+pkyiwtVz6g6z14AQ=; b=mnuJrU81khqbXUnEZEe27wChKv lhwucWSjtyIouGKQ+HNfnUktQxALGFqz2hJqbuZ1hbisAIq3trCrlepDzNVeJiHrPQNLWxuvdg0cl TgP3YsxxSHXYoDOP+tRX2C2Kt; Received: from 174-29-48-168.hlrn.qwest.net ([174.29.48.168]:37780 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hWT3s-0017Ed-Sf; Thu, 30 May 2019 16:58:13 -0500 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v3 4/8] Lock the demangled hash table References: <20190529212916.23721-1-tom@tromey.com> <20190529212916.23721-5-tom@tromey.com> <25f1c05d-c2ef-d229-1eef-1029186070b3@redhat.com> Date: Thu, 30 May 2019 21:58:00 -0000 In-Reply-To: <25f1c05d-c2ef-d229-1eef-1029186070b3@redhat.com> (Pedro Alves's message of "Thu, 30 May 2019 13:58:49 +0100") Message-ID: <871s0fehak.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-05/txt/msg00737.txt.bz2 >> This introduces a lock that is used when modifying the demangled hash >> table. Pedro> There's only a single mutex, and the comment says _THE_ demangled Pedro> hash table, but AFAICS, each per_bfd has its own table, right? Yes, that's correct. I'll fix the comment. Pedro> A single lock for every table compared to a lock per table might be Pedro> a good approach, but I'd welcome extended comments to explain Pedro> that design choice. I didn't want to put a mutex into the per-bfd object, mostly because it uses space for the entire lifetime of that, while the mutex is only used while demangling minsym names; and that can (currently) only be done for one objfile at a time. Tom