Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Alan Hayward <Alan.Hayward@arm.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>,
	 nd <nd@arm.com>
Subject: Re: [PATCH] AArch64 pauth: Indicate unmasked addresses in backtrace
Date: Thu, 18 Jul 2019 13:48:00 -0000	[thread overview]
Message-ID: <871rynzc5e.fsf@tromey.com> (raw)
In-Reply-To: <20190717081336.68835-1-alan.hayward@arm.com> (Alan Hayward's	message of "Wed, 17 Jul 2019 08:14:31 +0000")

>>>>> "Alan" == Alan Hayward <Alan.Hayward@arm.com> writes:

Alan> diff --git a/gdb/stack.c b/gdb/stack.c
Alan> index 9b1d1a6856..cef1c29a82 100644
Alan> --- a/gdb/stack.c
Alan> +++ b/gdb/stack.c
Alan> @@ -1254,7 +1254,11 @@ print_frame (const frame_print_options &fp_opts,
Alan>  	{
Alan>  	  annotate_frame_address ();
Alan>  	  if (pc_p)
Alan> -	    uiout->field_core_addr ("addr", gdbarch, pc);
Alan> +	    {
Alan> +	      uiout->field_core_addr ("addr", gdbarch, pc);
Alan> +	      if (frame_get_pc_masked (frame))
Alan> +		uiout->text ("<unmasked>");
Alan> +	    }

Usually a change to frame printing will require a change in the python
layer as well, because it has its own frame printer.  The ideal is that
a no-op frame filter should result in no change to the output.

thanks,
Tom


      parent reply	other threads:[~2019-07-18 13:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-17  8:14 Alan Hayward
2019-07-17 11:15 ` Pedro Alves
2019-07-17 13:36   ` Alan Hayward
2019-07-17 14:44     ` Pedro Alves
2019-07-17 15:02     ` Simon Marchi
2019-07-17 15:18       ` Pedro Alves
2019-07-17 16:07         ` Alan Hayward
2019-07-17 16:41           ` Pedro Alves
2019-07-17 17:34             ` Alan Hayward
2019-07-18 13:48 ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rynzc5e.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=Alan.Hayward@arm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox