From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110845 invoked by alias); 18 Jul 2019 13:48:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 110837 invoked by uid 89); 18 Jul 2019 13:48:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-19.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:824 X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.140) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 Jul 2019 13:48:49 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 14378EBA08 for ; Thu, 18 Jul 2019 08:48:46 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id o6m6hJQh590ono6m6hD8AA; Thu, 18 Jul 2019 08:48:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=lpHvp/X4/ZRZpDlEbeOVV5eD8f8feaGvtY9eDJj1JMc=; b=dc3kXTEw7a9JH46qz20d4TouuC njB5Twna6reCFJ1MS4WE5roVT9JmqjVTk5Qb7Oz4j2Nx5+/pWQ7Hy56HQEzahYO1MKffxX4r7PDYf 7G0TNl0A9zXH0Lur6OUDR1MvF; Received: from 97-122-178-82.hlrn.qwest.net ([97.122.178.82]:45284 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1ho6m6-003eDQ-Ds; Thu, 18 Jul 2019 08:48:46 -0500 From: Tom Tromey To: Alan Hayward Cc: "gdb-patches\@sourceware.org" , nd Subject: Re: [PATCH] AArch64 pauth: Indicate unmasked addresses in backtrace References: <20190717081336.68835-1-alan.hayward@arm.com> Date: Thu, 18 Jul 2019 13:48:00 -0000 In-Reply-To: <20190717081336.68835-1-alan.hayward@arm.com> (Alan Hayward's message of "Wed, 17 Jul 2019 08:14:31 +0000") Message-ID: <871rynzc5e.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-07/txt/msg00431.txt.bz2 >>>>> "Alan" == Alan Hayward writes: Alan> diff --git a/gdb/stack.c b/gdb/stack.c Alan> index 9b1d1a6856..cef1c29a82 100644 Alan> --- a/gdb/stack.c Alan> +++ b/gdb/stack.c Alan> @@ -1254,7 +1254,11 @@ print_frame (const frame_print_options &fp_opts, Alan> { Alan> annotate_frame_address (); Alan> if (pc_p) Alan> - uiout->field_core_addr ("addr", gdbarch, pc); Alan> + { Alan> + uiout->field_core_addr ("addr", gdbarch, pc); Alan> + if (frame_get_pc_masked (frame)) Alan> + uiout->text (""); Alan> + } Usually a change to frame printing will require a change in the python layer as well, because it has its own frame printer. The ideal is that a no-op frame filter should result in no change to the output. thanks, Tom