From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb] Make maint info sections print relocated addresses
Date: Thu, 15 Aug 2019 20:08:00 -0000 [thread overview]
Message-ID: <871rxmtcmo.fsf@tromey.com> (raw)
In-Reply-To: <20190814151458.GA22847@delia> (Tom de Vries's message of "Wed, 14 Aug 2019 17:15:00 +0200")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> gdb/ChangeLog:
Tom> 2019-08-14 Tom de Vries <tdevries@suse.de>
Tom> * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
Tom> print_objfile_section_info.
Thanks.
Tom> + if (arg && strcmp (arg, "ALLOBJ") == 0)
Tom> + {
Tom> + arg = NULL;
Tom> + allobj = true;
Tom> + }
It took me a minute to understand that this was equivalent to the old
code. It looked like the intent was to use match_substring, but then
other code defeated that. If this was more user-facing I'd say "ALLOBJ"
should be replaced with a real option; but since this is a maint command
I would not bother.
This patch is ok. Thanks.
Tom
prev parent reply other threads:[~2019-08-15 20:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 15:15 Tom de Vries
2019-08-15 20:08 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rxmtcmo.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox