From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46176 invoked by alias); 15 Aug 2019 20:08:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 46152 invoked by uid 89); 15 Aug 2019 20:08:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:756, minute X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.140) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 15 Aug 2019 20:08:50 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway34.websitewelcome.com (Postfix) with ESMTP id D5FD499183 for ; Thu, 15 Aug 2019 15:08:48 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id yM3EhcMh82qH7yM3EhbW3X; Thu, 15 Aug 2019 15:08:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QypBgLX/4xg0vmHuVWJllu6/e1A7DfXj9XAKko90jtY=; b=hI4Ot2xogl4yr5s6ZVuwgfhcU+ 0PGosfjSoSUj2+/1qlrKANMYuGqkxwAX2w4V1agbThoKKdZJftIY9NT1kvCgu7WYkWchE4OhQKo/x RdnaWJeXsgIuJfZMBW52yEa5t; Received: from 97-122-178-82.hlrn.qwest.net ([97.122.178.82]:52062 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hyM3E-001BJH-In; Thu, 15 Aug 2019 15:08:48 -0500 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH][gdb] Make maint info sections print relocated addresses References: <20190814151458.GA22847@delia> Date: Thu, 15 Aug 2019 20:08:00 -0000 In-Reply-To: <20190814151458.GA22847@delia> (Tom de Vries's message of "Wed, 14 Aug 2019 17:15:00 +0200") Message-ID: <871rxmtcmo.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-08/txt/msg00352.txt.bz2 >>>>> "Tom" == Tom de Vries writes: Tom> gdb/ChangeLog: Tom> 2019-08-14 Tom de Vries Tom> * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using Tom> print_objfile_section_info. Thanks. Tom> + if (arg && strcmp (arg, "ALLOBJ") == 0) Tom> + { Tom> + arg = NULL; Tom> + allobj = true; Tom> + } It took me a minute to understand that this was equivalent to the old code. It looked like the intent was to use match_substring, but then other code defeated that. If this was more user-facing I'd say "ALLOBJ" should be replaced with a real option; but since this is a maint command I would not bother. This patch is ok. Thanks. Tom