From: Tom Tromey <tom@tromey.com>
To: "Ijaz, Abdul B via Gdb-patches" <gdb-patches@sourceware.org>
Cc: "Ijaz, Abdul B" <abdul.b.ijaz@intel.com>,
Tom Tromey <tom@tromey.com>,
Andrew Burgess <andrew.burgess@embecosm.com>,
"abdul.b.ijaz" <abijaz@ecsmtp.iul.intel.com>
Subject: Re: [PATCH 1/1] gdb: Fix arrays of variable length strings for FORTRAN
Date: Fri, 15 Apr 2022 10:33:14 -0600 [thread overview]
Message-ID: <871qxy1f3p.fsf@tromey.com> (raw)
In-Reply-To: <CO1PR11MB47882920BEBE5C87DC8E1FBFCB449@CO1PR11MB4788.namprd11.prod.outlook.com> (Abdul B. via Gdb-patches Ijaz's message of "Wed, 29 Dec 2021 11:31:18 +0000")
> I do not feel so comfortable to modify generic code and my break
> things because of not having full overview. Will it be fine to merge
> this change if it is fine and not breaking anything or how shall we
> proceed on this. Thanks
I think it's best to address Andrew's review.
IIRC my comments can probably be deferred.
thanks,
Tom
next prev parent reply other threads:[~2022-04-15 16:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 11:06 [PATCH 0/1] Fix variable length strings array " abdul.b.ijaz via Gdb-patches
2021-08-20 11:06 ` [PATCH 1/1] gdb: Fix arrays of variable length strings " abdul.b.ijaz via Gdb-patches
2021-08-20 15:52 ` Andrew Burgess
2021-08-23 8:47 ` Ijaz, Abdul B via Gdb-patches
2021-08-25 8:36 ` Andrew Burgess
2021-08-27 9:11 ` Ijaz, Abdul B via Gdb-patches
2021-08-23 20:54 ` Tom Tromey
2021-08-25 8:56 ` Andrew Burgess
2021-08-27 17:02 ` Tom Tromey
2021-12-29 11:31 ` Ijaz, Abdul B via Gdb-patches
2022-04-11 14:51 ` Ijaz, Abdul B via Gdb-patches
2022-04-15 16:33 ` Tom Tromey [this message]
2021-08-20 17:02 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qxy1f3p.fsf@tromey.com \
--to=tom@tromey.com \
--cc=abdul.b.ijaz@intel.com \
--cc=abijaz@ecsmtp.iul.intel.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox