From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ZSk9ElmeWWKnbAAAWB0awg (envelope-from ) for ; Fri, 15 Apr 2022 12:33:29 -0400 Received: by simark.ca (Postfix, from userid 112) id 3AC691F327; Fri, 15 Apr 2022 12:33:29 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B219F1E150 for ; Fri, 15 Apr 2022 12:33:28 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1E0D53856DD5 for ; Fri, 15 Apr 2022 16:33:28 +0000 (GMT) Received: from gproxy2-pub.mail.unifiedlayer.com (gproxy2-pub.mail.unifiedlayer.com [69.89.18.3]) by sourceware.org (Postfix) with ESMTPS id 8767C385842B for ; Fri, 15 Apr 2022 16:33:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8767C385842B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway4.mail.pro1.eigbox.com (Postfix) with ESMTP id EA7CA10047788 for ; Fri, 15 Apr 2022 16:33:15 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id fOslnwDcakku4fOslnDjg4; Fri, 15 Apr 2022 16:33:15 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=XPf19StE c=1 sm=1 tr=0 ts=62599e4b a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=z0gMJWrwH1QA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=-v0bKgfh_3gzsHXiO9IA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=DP9TecZc8gPYv+QXW7sgcPip7E3FzvAY5AmTObaMpHg=; b=hQhEflQXNVkkIK2L2+2XTsBf23 hPbPSkL+1/rRlFryrgGOeYiXuHzCiGHjFQwHK8meU78q/4tewUknIcZUWj4KFnaC29X9SiVFMrfKt vbyEEX8gl+AT0VXgQznfPyCTl; Received: from 71-211-154-204.hlrn.qwest.net ([71.211.154.204]:55568 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nfOsl-0007B5-3J; Fri, 15 Apr 2022 10:33:15 -0600 From: Tom Tromey To: "Ijaz, Abdul B via Gdb-patches" Subject: Re: [PATCH 1/1] gdb: Fix arrays of variable length strings for FORTRAN References: <20210820110638.26648-1-abdul.b.ijaz@intel.com> <20210820110638.26648-2-abdul.b.ijaz@intel.com> <20210820155247.GA2581@embecosm.com> <87zgt7990i.fsf@tromey.com> <20210825085636.GG2581@embecosm.com> <87ilzqom68.fsf@tromey.com> X-Attribution: Tom Date: Fri, 15 Apr 2022 10:33:14 -0600 In-Reply-To: (Abdul B. via Gdb-patches Ijaz's message of "Wed, 29 Dec 2021 11:31:18 +0000") Message-ID: <871qxy1f3p.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.154.204 X-Source-L: No X-Exim-ID: 1nfOsl-0007B5-3J X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-154-204.hlrn.qwest.net (murgatroyd) [71.211.154.204]:55568 X-Source-Auth: tom+tromey.com X-Email-Count: 13 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Ijaz, Abdul B" , Tom Tromey , Andrew Burgess , "abdul.b.ijaz" Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > I do not feel so comfortable to modify generic code and my break > things because of not having full overview. Will it be fine to merge > this change if it is fine and not breaking anything or how shall we > proceed on this. Thanks I think it's best to address Andrew's review. IIRC my comments can probably be deferred. thanks, Tom