Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tom@tromey.com>,  Simon Marchi <simark@simark.ca>,
	 Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH 1/3] gdb: make get_interp_info return a reference
Date: Tue, 07 Mar 2023 13:45:36 -0700	[thread overview]
Message-ID: <871qm0qoi7.fsf@tromey.com> (raw)
In-Reply-To: <2526b60c-8a86-dc29-6c23-79a00461c591@simark.ca> (Simon Marchi via Gdb-patches's message of "Tue, 7 Mar 2023 15:34:27 -0500")

>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:

Simon> Here's what the patch looks like now:

Simon>    if (ui->interp_info == NULL)
Simon> -    ui->interp_info = XCNEW (struct ui_interp_info);
Simon> -  return ui->interp_info;
Simon> +    ui->interp_info = new ui_interp_info;

Unfortunately XCNEW -> new also means adding member initializers to
ensure they are 0.

Tom

  reply	other threads:[~2023-03-07 20:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-02 20:32 [PATCH 0/3] Some minor interps tweaks Simon Marchi via Gdb-patches
2023-03-02 20:32 ` [PATCH 1/3] gdb: make get_interp_info return a reference Simon Marchi via Gdb-patches
2023-03-07 19:27   ` Tom Tromey
2023-03-07 20:34     ` Simon Marchi via Gdb-patches
2023-03-07 20:45       ` Tom Tromey [this message]
2023-03-07 20:52         ` Simon Marchi via Gdb-patches
2023-03-07 21:29           ` Tom Tromey
2023-03-07 21:31             ` Simon Marchi via Gdb-patches
2023-03-02 20:32 ` [PATCH 2/3] gdb: make interp::m_name an `const char *` Simon Marchi via Gdb-patches
2023-03-07 19:29   ` Tom Tromey
2023-03-02 20:32 ` [PATCH 3/3] gdb: initialize interp::next Simon Marchi via Gdb-patches
2023-03-07 19:29   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871qm0qoi7.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    --cc=simon.marchi@efficios.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox