From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cNKhG36iB2SOwgcAWB0awg (envelope-from ) for ; Tue, 07 Mar 2023 15:45:50 -0500 Received: by simark.ca (Postfix, from userid 112) id 6C4921E223; Tue, 7 Mar 2023 15:45:50 -0500 (EST) Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=IxO90IvF; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 226F41E128 for ; Tue, 7 Mar 2023 15:45:50 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D4CE23854839 for ; Tue, 7 Mar 2023 20:45:49 +0000 (GMT) Received: from gproxy3-pub.mail.unifiedlayer.com (gproxy3-pub.mail.unifiedlayer.com [69.89.30.42]) by sourceware.org (Postfix) with ESMTPS id 4093F3858C2C for ; Tue, 7 Mar 2023 20:45:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4093F3858C2C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway5.mail.pro1.eigbox.com (Postfix) with ESMTP id ACA6A1004877B for ; Tue, 7 Mar 2023 20:45:38 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id ZeBmpTXL6WuSqZeBmpxCfh; Tue, 07 Mar 2023 20:45:38 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Vqrmv86n c=1 sm=1 tr=0 ts=6407a272 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=k__wU0fu6RkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=nCeVXGP4IGc0xHQ-rFcA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Si/FJuPw1YrTGVlHDNpguw4Nsb4cbNSM5U7yC8jS6j0=; b=IxO90IvFDHuNspc2RpoTf5MKhe Fkj8E1dt6ZQd7vaQq1En3lYn7NhpS8k2xR1MSd/llTPoVWwzqEyQdnKz4Ofthily90hIl7QuVfuwZ DuryrG4PUJLzW4/ZGm7HGndyC; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:60566 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pZeBm-001z1N-C6; Tue, 07 Mar 2023 13:45:38 -0700 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Tom Tromey , Simon Marchi , Simon Marchi Subject: Re: [PATCH 1/3] gdb: make get_interp_info return a reference References: <20230302203224.118345-1-simon.marchi@efficios.com> <20230302203224.118345-2-simon.marchi@efficios.com> <874jqws6o5.fsf@tromey.com> <2526b60c-8a86-dc29-6c23-79a00461c591@simark.ca> X-Attribution: Tom Date: Tue, 07 Mar 2023 13:45:36 -0700 In-Reply-To: <2526b60c-8a86-dc29-6c23-79a00461c591@simark.ca> (Simon Marchi via Gdb-patches's message of "Tue, 7 Mar 2023 15:34:27 -0500") Message-ID: <871qm0qoi7.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pZeBm-001z1N-C6 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net (murgatroyd) [75.166.130.93]:60566 X-Source-Auth: tom+tromey.com X-Email-Count: 13 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> Here's what the patch looks like now: Simon> if (ui->interp_info == NULL) Simon> - ui->interp_info = XCNEW (struct ui_interp_info); Simon> - return ui->interp_info; Simon> + ui->interp_info = new ui_interp_info; Unfortunately XCNEW -> new also means adding member initializers to ensure they are 0. Tom