Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v5 2/3] [gdb/exp] Fix ignoring of incorrect namespace prefix
Date: Fri, 01 May 2026 13:44:50 -0600	[thread overview]
Message-ID: <871pfuhq31.fsf@tromey.com> (raw)
In-Reply-To: <20260419081236.570600-3-tdevries@suse.de> (Tom de Vries's message of "Sun, 19 Apr 2026 10:12:35 +0200")

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> +	      const char *current_scope = (block->function_block () != nullptr
Tom> +					   ? block->scope ()
Tom> +					   : nullptr /* Don't know.  */);

Calling block::scope would yield "" even for the static block case.
So I was wondering why not use that rather than check function_block?
But like I said elsewhere, I don't really follow this function that well.

thanks,
Tom

  reply	other threads:[~2026-05-01 19:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-19  8:12 [PATCH v5 0/3] [gdb/exp] Fix some namespace issues Tom de Vries
2026-04-19  8:12 ` [PATCH v5 1/3] [gdb] Break up complex assignment in cp_lookup_symbol_via_imports Tom de Vries
2026-04-19  8:12 ` [PATCH v5 2/3] [gdb/exp] Fix ignoring of incorrect namespace prefix Tom de Vries
2026-05-01 19:44   ` Tom Tromey [this message]
2026-05-12 10:15     ` Tom de Vries
2026-05-12 10:24       ` Tom de Vries
2026-04-19  8:12 ` [PATCH v5 3/3] [gdb/exp] Handle recursive namespace import Tom de Vries
2026-05-01 19:37   ` Tom Tromey
2026-05-12 10:22     ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871pfuhq31.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox