From: Yao Qi <qiyaoltc@gmail.com>
To: "Maciej W. Rozycki" <macro@imgtec.com>
Cc: <gdb-patches@sourceware.org>, Yao Qi <yao.qi@linaro.org>,
Joel Brobecker <brobecker@adacore.com>
Subject: Re: [PATCH] mem-break: Fix breakpoint insertion location
Date: Fri, 04 Aug 2017 13:24:00 -0000 [thread overview]
Message-ID: <86zibf1n5e.fsf@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1708011707230.29991@tp.orcam.me.uk> (Maciej W. Rozycki's message of "Tue, 1 Aug 2017 17:36:53 +0100")
"Maciej W. Rozycki" <macro@imgtec.com> writes:
> Fix a commit cd6c3b4ffc4e ("New gdbarch methods breakpoint_kind_from_pc
> and sw_breakpoint_from_kind") regression and restore the use of
> ->placed_size rather than ->reqstd_address as the location for a memory
s/placed_size/placed_address/
The patch looks good to me, but please give me two or three days to run
the tests on an armv7 board. The board is being used for other tests,
and I'll start the regression test on Monday next week.
--
Yao (齐尧)
next prev parent reply other threads:[~2017-08-04 13:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 16:36 Maciej W. Rozycki
2017-08-02 17:53 ` Maciej W. Rozycki
2017-08-04 13:17 ` Simon Marchi
2017-08-04 13:58 ` Maciej W. Rozycki
2017-08-04 13:24 ` Yao Qi [this message]
2017-08-04 14:13 ` [PATCH v2] PR breakpoints/21886: " Maciej W. Rozycki
2017-08-07 15:35 ` Yao Qi
2017-08-07 16:05 ` Maciej W. Rozycki
2017-08-09 7:44 ` Yao Qi
2017-08-11 14:31 ` Maciej W. Rozycki
2017-08-11 15:12 ` Yao Qi
2017-08-11 16:14 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86zibf1n5e.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=macro@imgtec.com \
--cc=yao.qi@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox