From: Yao Qi <qiyaoltc@gmail.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: Sergio Durigan Junior <sergiodj@redhat.com>,
GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH/RFA] Do not emit "field_type" var if not needed on "maint print c-tdesc"
Date: Thu, 21 Dec 2017 09:10:00 -0000 [thread overview]
Message-ID: <86zi6cjvji.fsf@gmail.com> (raw)
In-Reply-To: <9ed3a5f3-f8ea-9a87-d201-40cfb0abd67e@ericsson.com> (Simon Marchi's message of "Tue, 19 Dec 2017 15:15:45 -0500")
Simon Marchi <simon.marchi@ericsson.com> writes:
> A simpler way would be to emit the field lazily when we actually need it, see patch
> below for an example. There's a bit more collateral damage in the generated files,
> since some declarations change place. We would need to do the same for the other
> variable declarations.
Yes, your patch in target-descriptions.c is simpler. The patch is good
to me.
--
Yao (齐尧)
next prev parent reply other threads:[~2017-12-21 9:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 19:18 Sergio Durigan Junior
2017-12-19 20:16 ` Simon Marchi
2017-12-19 20:51 ` Sergio Durigan Junior
2017-12-21 9:10 ` Yao Qi [this message]
2017-12-21 23:24 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86zi6cjvji.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox