From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122709 invoked by alias); 21 Dec 2017 09:10:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 122686 invoked by uid 89); 21 Dec 2017 09:10:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:510, H*r:sk:static. X-HELO: mail-wm0-f51.google.com Received: from mail-wm0-f51.google.com (HELO mail-wm0-f51.google.com) (74.125.82.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Dec 2017 09:10:48 +0000 Received: by mail-wm0-f51.google.com with SMTP id f206so14339651wmf.5 for ; Thu, 21 Dec 2017 01:10:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=+dgzZQClx8YSUwsDBbhHaXKjcc/lzv8csPMzpTycFlw=; b=NF+7Ir7di1X1T6FIFxlERkluvKh4QCAobTHUljj61x4VXWgQVaa/A1sc31MwdtlD0B 3ZLiXnwgR2QnnJ/7T7n2m2CEnWX6FeqFkiyQLpft3i5okJzcQzHX9UbqNI6FUXKXVF5o lCzKEyx/EjC1OSCtBmAIHm02d5xvXGQ2YdH3RMnpZdXk5W1eC3CFdlst0a4Dy+6uxHma LpOInrRifv2b5jElVEpRCv8VGoREDoAWBci74iVJvEcbdq9gxIZIabtzD+wTRL2/73fQ girm8VenGfFrON0dB5OoDju85RfXYteTGi6WVWMO4Wi8DdRiz5dx93KpzGLvz6oU3BLB Qfsg== X-Gm-Message-State: AKGB3mJTZqT64o5uMLbKM3f4MnsnQUlBNbNm/L0V2lDfHNj9fax20vCl QD+JySs97CAGx5yIq1CDFSpPLQ== X-Google-Smtp-Source: ACJfBouNwb/zDxZ7xzivUzzCi7aY2xwi09ZVPA0EvkHlPvEWErrt0f6t9XjBUafPVGWbI79OuBzipw== X-Received: by 10.28.110.24 with SMTP id j24mr8482745wmc.100.1513847446214; Thu, 21 Dec 2017 01:10:46 -0800 (PST) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id p90sm18800690wrb.28.2017.12.21.01.10.45 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 21 Dec 2017 01:10:45 -0800 (PST) From: Yao Qi To: Simon Marchi Cc: Sergio Durigan Junior , GDB Patches Subject: Re: [PATCH/RFA] Do not emit "field_type" var if not needed on "maint print c-tdesc" References: <20171219191817.7554-1-sergiodj@redhat.com> <9ed3a5f3-f8ea-9a87-d201-40cfb0abd67e@ericsson.com> Date: Thu, 21 Dec 2017 09:10:00 -0000 In-Reply-To: <9ed3a5f3-f8ea-9a87-d201-40cfb0abd67e@ericsson.com> (Simon Marchi's message of "Tue, 19 Dec 2017 15:15:45 -0500") Message-ID: <86zi6cjvji.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00466.txt.bz2 Simon Marchi writes: > A simpler way would be to emit the field lazily when we actually need it,= see patch > below for an example. There's a bit more collateral damage in the genera= ted files, > since some declarations change place. We would need to do the same for t= he other > variable declarations. Yes, your patch in target-descriptions.c is simpler. The patch is good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)