From: Yao Qi <qiyaoltc@gmail.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] arm-tdep.c: Change type of insn parameters
Date: Thu, 11 Feb 2016 10:58:00 -0000 [thread overview]
Message-ID: <86wpqbpl7m.fsf@gmail.com> (raw)
In-Reply-To: <1455146137-30672-1-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Wed, 10 Feb 2016 18:15:37 -0500")
Simon Marchi <simon.marchi@ericsson.com> writes:
> /* Copy 16-bit Thumb(Thumb and 16-bit Thumb-2) instruction without any
> modification. */
> static int
> -thumb_copy_unmodified_16bit (struct gdbarch *gdbarch, unsigned int insn,
> +thumb_copy_unmodified_16bit (struct gdbarch *gdbarch, uint32_t insn,
> const char *iname,
> struct displaced_step_closure *dsc)
The instruction here is 16-bit, so we should use "uint16_t".
OK with the change.
--
Yao (齐尧)
next prev parent reply other threads:[~2016-02-11 10:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 23:15 Simon Marchi
2016-02-11 10:58 ` Yao Qi [this message]
2016-02-11 18:22 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86wpqbpl7m.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox