From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93917 invoked by alias); 11 Feb 2016 10:58:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93906 invoked by uid 89); 11 Feb 2016 10:58:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-pf0-f178.google.com Received: from mail-pf0-f178.google.com (HELO mail-pf0-f178.google.com) (209.85.192.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 11 Feb 2016 10:58:43 +0000 Received: by mail-pf0-f178.google.com with SMTP id c10so28226540pfc.2 for ; Thu, 11 Feb 2016 02:58:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type :content-transfer-encoding; bh=4Im3dFzOFY8XraZ98+I8kWft0RdcZ7IeyKMM83WQjYI=; b=AYRe1SkwLJiJYgMFtmn/+nbYJwWO6rtkHLXSuFSuUC2JmniU3uVmijTEZUv+wASnIJ 7rdNLsVyxGWG/AOi5nhMAUQ3ZXbwLklqxCbZpvJXxUCim4LUOzyfNNvt3M+fA6Jc/s/e sMQ7XyHF3gHfGHidg4nycrEjkgz1D+MMNxqrJ7rjyFeqvXkXRER2GPmONV2TKl4T4eLP QQQbtEl+Qum0WOPN6x7UH0W+2FXhTzF5dzFqAL9VP8fejwhszGZK8JrvZpPOyYar0CIT EbICaXIyCFn+/7FHDQU/jLpixu38uDeUN+vQy/jAwVSQw3rFy1m7KQqk8GCpXfN+8s4+ QobQ== X-Gm-Message-State: AG10YORibEb26+kBOFzN8GtRnAA9sjZ6YTCx+BpmQLaKhkRAjUaUIGbCypuKgifyQGUMOQ== X-Received: by 10.98.17.28 with SMTP id z28mr52658541pfi.38.1455188321608; Thu, 11 Feb 2016 02:58:41 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id 82sm11447170pfn.89.2016.02.11.02.58.40 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 11 Feb 2016 02:58:41 -0800 (PST) From: Yao Qi To: Simon Marchi Cc: Subject: Re: [PATCH] arm-tdep.c: Change type of insn parameters References: <1455146137-30672-1-git-send-email-simon.marchi@ericsson.com> Date: Thu, 11 Feb 2016 10:58:00 -0000 In-Reply-To: <1455146137-30672-1-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Wed, 10 Feb 2016 18:15:37 -0500") Message-ID: <86wpqbpl7m.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00338.txt.bz2 Simon Marchi writes: > /* Copy 16-bit Thumb(Thumb and 16-bit Thumb-2) instruction without any > modification. */ > static int > -thumb_copy_unmodified_16bit (struct gdbarch *gdbarch, unsigned int insn, > +thumb_copy_unmodified_16bit (struct gdbarch *gdbarch, uint32_t insn, > const char *iname, > struct displaced_step_closure *dsc) The instruction here is 16-bit, so we should use "uint16_t". OK with the change. --=20 Yao (=E9=BD=90=E5=B0=A7)