From: Yao Qi <qiyaoltc@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: Yao Qi <qiyaoltc@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Clear *VAL in regcache_raw_read_unsigned
Date: Fri, 12 Feb 2016 11:15:00 -0000 [thread overview]
Message-ID: <86vb5unps0.fsf@gmail.com> (raw)
In-Reply-To: <56BCC3B1.5090400@redhat.com> (Pedro Alves's message of "Thu, 11 Feb 2016 17:24:01 +0000")
Pedro Alves <palves@redhat.com> writes:
Hi Pedro,
> I just don't see what the worry is. OTOH, sharing the routines
> would pave to way to share more, and have one less diverging detail
> to worry about, avoiding proliferation of "bridging" interfaces like
> regcache_raw_read_unsigned or the need to hook in more entry points
> to get_next_pcs and whatever else we put in shared code areas.
I don't worry about the code sharing. I am OK with your patches moving
bfd_endian to a separate header and fix the issue in
regcache_raw_read_unsigned with extract_unsigned_integer.
--
Yao (齐尧)
prev parent reply other threads:[~2016-02-12 11:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 14:54 Yao Qi
2016-02-10 16:45 ` Yao Qi
2016-02-10 16:52 ` Pedro Alves
2016-02-10 17:25 ` Yao Qi
2016-02-10 17:36 ` Pedro Alves
2016-02-11 10:12 ` Yao Qi
2016-02-11 12:46 ` Pedro Alves
2016-02-11 15:15 ` Yao Qi
2016-02-11 15:51 ` Pedro Alves
2016-02-11 16:32 ` Antoine Tremblay
2016-02-11 17:00 ` Yao Qi
2016-02-11 17:24 ` Pedro Alves
2016-02-12 11:15 ` Yao Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86vb5unps0.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox