From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72398 invoked by alias); 12 Feb 2016 11:15:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71365 invoked by uid 89); 12 Feb 2016 11:15:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-pf0-f173.google.com Received: from mail-pf0-f173.google.com (HELO mail-pf0-f173.google.com) (209.85.192.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 12 Feb 2016 11:15:18 +0000 Received: by mail-pf0-f173.google.com with SMTP id x65so46227662pfb.1 for ; Fri, 12 Feb 2016 03:15:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type :content-transfer-encoding; bh=zbh59k6XtjGPA1sEX/KToGoL0ky2nlZQM0cKk4seUx4=; b=IuVTg0PHg2xqE3vX2D7AwWQ+x2BsexpGkQ5dvxNLEKPLO3pc6lznfiYeHxDHkRV+lk Q3B2u8Am7wAkBXSnxKzVjHQr+L6TBi+rcCo+ALEZXj1S7k39o7Q3nMborTRp6UN+jPfl qKpIz++x3IcyolHHhqJT3TJZ4PyhlMq+rS4GpDiQ7y+MpgSVIa6QoZ3Im52/xVUkM+8x /11xJMf+dKO51gvw3+SKdpOjoAIzf+M42xvIqYDInDi+evkzTNK2/JRxMWiH0TJYy+dq 4g6fUQOXaZ8619tbEo7HMx6tZnDTFbHpXm7CnkSrUlGIQwqIN5gKaJzvfCkc78jm87PU WRJg== X-Gm-Message-State: AG10YOTkYOqaDbdAOXuEpywocf4+HJvXBQMkjfOviWxSEti+n1KohHMaR71CRX9sor/+Zw== X-Received: by 10.98.33.70 with SMTP id h67mr1260514pfh.54.1455275716524; Fri, 12 Feb 2016 03:15:16 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id dg12sm18731244pac.47.2016.02.12.03.15.14 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 12 Feb 2016 03:15:15 -0800 (PST) From: Yao Qi To: Pedro Alves Cc: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH] Clear *VAL in regcache_raw_read_unsigned References: <1455029644-6197-1-git-send-email-yao.qi@linaro.org> <86egckqztq.fsf@gmail.com> <56BB6ADB.6070909@redhat.com> <86a8n8qxyp.fsf@gmail.com> <56BB7512.2030507@redhat.com> <8660xvr1wr.fsf@gmail.com> <56BC829B.8060102@redhat.com> <864mdfp9b3.fsf@gmail.com> <56BCAE02.7030803@redhat.com> <56BCBE08.6040306@gmail.com> <56BCC3B1.5090400@redhat.com> Date: Fri, 12 Feb 2016 11:15:00 -0000 In-Reply-To: <56BCC3B1.5090400@redhat.com> (Pedro Alves's message of "Thu, 11 Feb 2016 17:24:01 +0000") Message-ID: <86vb5unps0.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00404.txt.bz2 Pedro Alves writes: Hi Pedro, > I just don't see what the worry is. OTOH, sharing the routines > would pave to way to share more, and have one less diverging detail > to worry about, avoiding proliferation of "bridging" interfaces like > regcache_raw_read_unsigned or the need to hook in more entry points > to get_next_pcs and whatever else we put in shared code areas. I don't worry about the code sharing. I am OK with your patches moving bfd_endian to a separate header and fix the issue in regcache_raw_read_unsigned with extract_unsigned_integer. --=20 Yao (=E9=BD=90=E5=B0=A7)