Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <qiyaoltc@gmail.com>
To: Pierre Langlois <pierre.langlois@arm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] [testsuite] Add test case for tracepoints with conditions
Date: Wed, 16 Sep 2015 09:19:00 -0000	[thread overview]
Message-ID: <86twqu202u.fsf@gmail.com> (raw)
In-Reply-To: <1441992301-26779-3-git-send-email-pierre.langlois@arm.com>	(Pierre Langlois's message of "Fri, 11 Sep 2015 18:25:01 +0100")

Pierre Langlois <pierre.langlois@arm.com> writes:

> +clean_restart ${executable}
> +
> +if ![runto_main] {
> +    fail "Can't run to main for ftrace tests"
> +    return 0
> +}
> +
> +gdb_reinitialize_dir $srcdir/$subdir

Don't need gdb_reinitialize_dir, as clean_restart did that already.

The patch is OK.

-- 
Yao (齐尧)


  reply	other threads:[~2015-09-16  9:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-11 17:25 [PATCH 0/2] [GDBserver] Fix compiling conditional expressions accessing registers Pierre Langlois
2015-09-11 17:25 ` [PATCH 2/2] [testsuite] Add test case for tracepoints with conditions Pierre Langlois
2015-09-16  9:19   ` Yao Qi [this message]
2015-09-17  8:51   ` Yao Qi
2015-09-11 17:25 ` [PATCH 1/2] [GDBserver] Fix compiling conditional expressions accessing registers Pierre Langlois
2015-09-16  9:15   ` Yao Qi
2015-09-16 11:50     ` Ulrich Weigand
2015-09-16 13:54       ` Pedro Alves
2015-09-16 15:03         ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86twqu202u.fsf@gmail.com \
    --to=qiyaoltc@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pierre.langlois@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox