Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <qiyaoltc@gmail.com>
To: Jon Boden <jon@ubuntubsd.org>
Cc: Yao Qi <qiyaoltc@gmail.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH] Re: Patch for GNU/kFreeBSD
Date: Thu, 19 May 2016 13:34:00 -0000	[thread overview]
Message-ID: <86twhu894x.fsf@gmail.com> (raw)
In-Reply-To: <20160517203454.GA8967@ubuntubsd.org> (Jon Boden's message of	"Tue, 17 May 2016 22:34:54 +0200")

Jon Boden <jon@ubuntubsd.org> writes:

> Yes. GDB needs kinfo_getvmmap() on GNU/kFreeBSD systems same as on
> pure FreeBSD. However on these systems the FreeBSD version of libutil
> is renamed to libutil-freebsd.

Thanks for the explanation.  Could you write this explanation down in
configure.ac close to your change as a comment?  so people can
understand easily why do we check util and util-freebsd.

>
>> You also need to regenerate configure file, and
>> include the changes in the patch too.  ChangeLog is needed as well.
>
> Done! For ChangeLog:
>
> 2016-05-17  Jon Boden  <jon@ubuntubsd.org>
>
> 	* configure.ac: Search for libutil-freebsd as alternative to libutil.

You also need

	* configure: Re-generated.

otherwise, patch is good to me.  If you don't have the account to push
your patch in, I can do it for you.

-- 
Yao (齐尧)


  reply	other threads:[~2016-05-19 13:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-13 20:58 Jon Boden
2016-05-16 13:09 ` Yao Qi
2016-05-17 20:35   ` [PATCH] " Jon Boden
2016-05-19 13:34     ` Yao Qi [this message]
2016-05-21  8:06       ` Jon Boden
2016-05-23  7:51         ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86twhu894x.fsf@gmail.com \
    --to=qiyaoltc@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jon@ubuntubsd.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox