From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2954 invoked by alias); 19 May 2016 13:34:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2936 invoked by uid 89); 19 May 2016 13:34:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS,URIBL_RHS_DOB autolearn=ham version=3.3.2 spammy= X-HELO: mail-pa0-f65.google.com Received: from mail-pa0-f65.google.com (HELO mail-pa0-f65.google.com) (209.85.220.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 19 May 2016 13:34:01 +0000 Received: by mail-pa0-f65.google.com with SMTP id rw9so7952102pab.2 for ; Thu, 19 May 2016 06:34:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=pD2FY2ouaCfR/lw9Q4jEH56Y+8Z217Gy/R1M/5NUaMY=; b=HAnX3ekRb217dUf0eG0VgFR08oehhzgXvo6oayrumzWXVvxfjjn/FrAAQF27q9Z/YP EInB0NtZOKLoFXQSOQpjCQ0LVyeyy5e5tWpnMaY1Zz0eQodPDyU5t7CCIWAJ2Ub+t92U GQrnpLm3zibMdruQ8vbrReIarlm0Wsck3ADVbsB14I7ueVGpqHF+qnXPrk/NG/f0aGhx MwkZUvi/8YKlbQXMi79VigssoNI6WgG3ku1Eig0UKzDosUwmSgIGyXfRUayYoK9aaqW1 uZ81IS8nxP0Ip6IBpAfp4s0ow9A3ECNDgpP46VifZ5sFCLZHtWe972Eb/CYq3yKZjHnI Axpw== X-Gm-Message-State: AOPr4FVRWKgzwcDRZEhSWa63zAByN8PGSR4BTCGt21ljM0VEvlJvXm6YzJeBpJ437ZToCw== X-Received: by 10.66.221.167 with SMTP id qf7mr19709235pac.94.1463664839453; Thu, 19 May 2016 06:33:59 -0700 (PDT) Received: from E107787-LIN (gcc113.osuosl.org. [140.211.9.71]) by smtp.gmail.com with ESMTPSA id 71sm20092500pfy.32.2016.05.19.06.33.56 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 19 May 2016 06:33:58 -0700 (PDT) From: Yao Qi To: Jon Boden Cc: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH] Re: Patch for GNU/kFreeBSD References: <20160513205750.GA23358@ubuntubsd.org> <86k2iu9ml8.fsf@gmail.com> <20160517203454.GA8967@ubuntubsd.org> Date: Thu, 19 May 2016 13:34:00 -0000 In-Reply-To: <20160517203454.GA8967@ubuntubsd.org> (Jon Boden's message of "Tue, 17 May 2016 22:34:54 +0200") Message-ID: <86twhu894x.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg00326.txt.bz2 Jon Boden writes: > Yes. GDB needs kinfo_getvmmap() on GNU/kFreeBSD systems same as on > pure FreeBSD. However on these systems the FreeBSD version of libutil > is renamed to libutil-freebsd. Thanks for the explanation. Could you write this explanation down in configure.ac close to your change as a comment? so people can understand easily why do we check util and util-freebsd. > >> You also need to regenerate configure file, and >> include the changes in the patch too. ChangeLog is needed as well. > > Done! For ChangeLog: > > 2016-05-17 Jon Boden > > * configure.ac: Search for libutil-freebsd as alternative to libutil. You also need * configure: Re-generated. otherwise, patch is good to me. If you don't have the account to push your patch in, I can do it for you. --=20 Yao (=E9=BD=90=E5=B0=A7)