Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <qiyaoltc@gmail.com>
To: Alan Hayward <Alan.Hayward@arm.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>,
	 nd <nd@arm.com>
Subject: Re: [PATCH 6/11] Add ALPHA_MAX_REGISTER_SIZE
Date: Tue, 06 Jun 2017 14:02:00 -0000	[thread overview]
Message-ID: <86tw3t1ag0.fsf@gmail.com> (raw)
In-Reply-To: <D67714E2-1EDC-4CBF-9C79-964140C47671@arm.com> (Alan Hayward's	message of "Mon, 5 Jun 2017 16:25:16 +0000")

Alan Hayward <Alan.Hayward@arm.com> writes:

> I don't have a ALPHA machine to test on.
> Tested on a --enable-targets=all and --enable-libsanitizer build using
> make check with board files unix and native-gdbserver.

Could you build GDB with option -fsanitize=address
(make CXXFLAGS='-fsanitize=address') and run gdb.gdb/unittest.exp?

>
> Ok to commit?
>

OK if there is no fail in unit tests.

> Alan.
>
> 2017-05-30  Alan Hayward  <alan.hayward@arm.com>
>
> 	* alpha-tdep.c (alpha_register_to_value): Use get_frame_register_value.

This line is too long.  The line max length in ChangeLog is 74.
https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_Formatted_GNU_ChangeLog

> 	(alpha_value_to_register): Use ALPHA_REGISTER_SIZE.

-- 
Yao (齐尧)


  reply	other threads:[~2017-06-06 14:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-04 10:14 Alan Hayward
2017-04-11  9:16 ` Yao Qi
     [not found]   ` <EED29198-B67C-4BD6-B4A8-12D75CD7A11B@arm.com>
2017-06-05 16:25     ` Alan Hayward
2017-06-06 14:02       ` Yao Qi [this message]
2017-06-06 14:47         ` Alan Hayward

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86tw3t1ag0.fsf@gmail.com \
    --to=qiyaoltc@gmail.com \
    --cc=Alan.Hayward@arm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox