Re: [PATCH 6/11] Add ALPHA_MAX_REGISTER_SIZE

[Alan Hayward <Alan.Hayward@arm.com>]

> On 6 Jun 2017, at 15:02, Yao Qi <qiyaoltc@gmail.com> wrote:
> 
> Alan Hayward <Alan.Hayward@arm.com> writes:
> 
>> I don't have a ALPHA machine to test on.
>> Tested on a --enable-targets=all and --enable-libsanitizer build using
>> make check with board files unix and native-gdbserver.
> 
> Could you build GDB with option -fsanitize=address
> (make CXXFLAGS='-fsanitize=address') and run gdb.gdb/unittest.exp?
> 
>> 
>> Ok to commit?
>> 
> 
> OK if there is no fail in unit tests.

Tested along with the IA64 patch.
unittest.exp passes.


> 
>> Alan.
>> 
>> 2017-05-30  Alan Hayward  <alan.hayward@arm.com>
>> 
>> 	* alpha-tdep.c (alpha_register_to_value): Use get_frame_register_value.
> 
> This line is too long.  The line max length in ChangeLog is 74.
> https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_Formatted_GNU_ChangeLog

Sorry, that was new to me (As far as I’m aware, gcc uses 80).


> 
>> 	(alpha_value_to_register): Use ALPHA_REGISTER_SIZE.
> 
> 

Committed with newline added in changelog.


Alan.