From: Yao Qi <qiyaoltc@gmail.com>
To: James Bowman <james.bowman@ftdichip.com>
Cc: Doug Evans <dje@google.com>, Yao Qi <qiyaoltc@gmail.com>,
"gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH, FT32] Proper support for address <-> pointer conversions
Date: Wed, 23 Sep 2015 07:46:00 -0000 [thread overview]
Message-ID: <86si65a890.fsf@gmail.com> (raw)
In-Reply-To: <CA9BBF0458F83C4F9051448B941B57D119615004@glaexch1> (James Bowman's message of "Tue, 22 Sep 2015 22:09:00 +0000")
James Bowman <james.bowman@ftdichip.com> writes:
> 2015-09-22 James Bowman <james.bowman@ftdichip.com>
>
> * ft32-tdep.c: Add "pointer_to_address" gdbarch method.
> Add "address_class_type_flags" gdbarch method.
> Add "address_class_name_to_type" gdbarch method.
> Add "address_class_type_flags_to_name" gdbarch method.
> * ft32-tdep.h (struct gdbarch_tdep): Add pc_type.
>
The ChangeLog is still wrong to me. You need also read GNU coding
standard, https://www.gnu.org/prep/standards/standards.html
* ft32-tdep.c (ft32_register_type): Return gdbarch_tdep (gdbarch)->pc_type
instead of builtin_func_ptr.
(ft32_pointer_to_address): New function.
(ft32_address_class_type_flags): New function.
(ft32_address_class_type_flags_to_name): New function.
(ft32_address_class_name_to_type_flags): New function.
(ft32_gdbarch_init): Set tdep->pc_type. Call
set_gdbarch_pointer_to_address,
set_gdbarch_address_class_type_flags
set_gdbarch_address_class_name_to_type_flags,
and set_gdbarch_address_class_type_flags_to_name.
* ft32-tdep.h (struct gdbarch_tdep) <pc_type>: New field.
Otherwise, the patch looks good to me.
--
Yao (齐尧)
prev parent reply other threads:[~2015-09-23 7:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 23:07 James Bowman
2015-09-22 16:36 ` Yao Qi
2015-09-22 18:38 ` James Bowman
2015-09-22 19:54 ` Doug Evans
2015-09-22 22:10 ` James Bowman
2015-09-23 7:46 ` Yao Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86si65a890.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=james.bowman@ftdichip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox