From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45810 invoked by alias); 23 Sep 2015 07:46:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 45799 invoked by uid 89); 23 Sep 2015 07:46:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f44.google.com Received: from mail-pa0-f44.google.com (HELO mail-pa0-f44.google.com) (209.85.220.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 23 Sep 2015 07:46:10 +0000 Received: by pablk4 with SMTP id lk4so2296877pab.3 for ; Wed, 23 Sep 2015 00:46:08 -0700 (PDT) X-Received: by 10.68.239.69 with SMTP id vq5mr35404988pbc.111.1442994368855; Wed, 23 Sep 2015 00:46:08 -0700 (PDT) Received: from E107787-LIN (power-aix.osuosl.org. [140.211.15.154]) by smtp.gmail.com with ESMTPSA id jv5sm6222180pbc.47.2015.09.23.00.46.05 (version=TLS1_2 cipher=AES128-SHA256 bits=128/128); Wed, 23 Sep 2015 00:46:07 -0700 (PDT) From: Yao Qi To: James Bowman Cc: Doug Evans , Yao Qi , "gdb-patches\@sourceware.org" Subject: Re: [PATCH, FT32] Proper support for address <-> pointer conversions References: <86wpvi9zst.fsf@gmail.com> Date: Wed, 23 Sep 2015 07:46:00 -0000 In-Reply-To: (James Bowman's message of "Tue, 22 Sep 2015 22:09:00 +0000") Message-ID: <86si65a890.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00544.txt.bz2 James Bowman writes: > 2015-09-22 James Bowman > > * ft32-tdep.c: Add "pointer_to_address" gdbarch method. > Add "address_class_type_flags" gdbarch method. > Add "address_class_name_to_type" gdbarch method. > Add "address_class_type_flags_to_name" gdbarch method. > * ft32-tdep.h (struct gdbarch_tdep): Add pc_type. > The ChangeLog is still wrong to me. You need also read GNU coding standard, https://www.gnu.org/prep/standards/standards.html * ft32-tdep.c (ft32_register_type): Return gdbarch_tdep (gdbarch)->pc_type instead of builtin_func_ptr. (ft32_pointer_to_address): New function. (ft32_address_class_type_flags): New function. (ft32_address_class_type_flags_to_name): New function. (ft32_address_class_name_to_type_flags): New function. (ft32_gdbarch_init): Set tdep->pc_type. Call set_gdbarch_pointer_to_address, set_gdbarch_address_class_type_flags set_gdbarch_address_class_name_to_type_flags, and set_gdbarch_address_class_type_flags_to_name. * ft32-tdep.h (struct gdbarch_tdep) : New field. Otherwise, the patch looks good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)